Commit e3db8556 authored by maruel@chromium.org's avatar maruel@chromium.org

Fix drover regression introduced in r80453.

getSVNInfo() is expected to fail in some use case. Make this behavior explicit.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6881008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81970 0039d316-1c4b-4281-b951-d872f2087c98
parent 6fb99c6f
......@@ -64,14 +64,16 @@ def gclUpload(revision, author):
return runGcl(command)
def getSVNInfo(url, revision):
svn_info = subprocess2.check_output(
['svn', 'info', '%s@%s' % (url, revision)]).splitlines()
info = {}
for line in svn_info:
match = re.search(r"(.*?):(.*)", line)
if match:
info[match.group(1).strip()]=match.group(2).strip()
try:
svn_info = subprocess2.check_output(
['svn', 'info', '%s@%s' % (url, revision)]).splitlines()
for line in svn_info:
match = re.search(r"(.*?):(.*)", line)
if match:
info[match.group(1).strip()] = match.group(2).strip()
except subprocess2.CalledProcessError:
pass
return info
def isSVNDirty():
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment