Make gcl and git-cl don't throw when a vim user does :cg

That's just noise for the maintainer.

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/6985002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84803 0039d316-1c4b-4281-b951-d872f2087c98

gcl.py

@@ -1119,8 +1119,12 @@ def CMDchange(args):
       if sys.platform == 'win32' and os.environ.get('TERM') == 'msys':
         # Msysgit requires the usage of 'env' to be present.
         cmd = 'env ' + cmd
-      # shell=True to allow the shell to handle all forms of quotes in $EDITOR.
-      subprocess.check_call(cmd, shell=True)
+      try:
+        # shell=True to allow the shell to handle all forms of quotes in
+        # $EDITOR.
+        subprocess.check_call(cmd, shell=True)
+      except subprocess.CalledProcessError, e:
+        ErrorExit('Editor returned %d' % e.returncode)
     result = gclient_utils.FileRead(filename, 'r')
   finally:
     os.remove(filename)

git_cl.py

@@ -842,7 +842,10 @@ def UserEditedLog(starting_text):
       # Msysgit requires the usage of 'env' to be present.
       cmd = 'env ' + cmd
     # shell=True to allow the shell to handle all forms of quotes in $EDITOR.
-    subprocess.check_call(cmd, shell=True)
+    try:
+      subprocess.check_call(cmd, shell=True)
+    except subprocess.CalledProcessError, e:
+      DieWithError('Editor returned %d' % e.returncode)
     fileobj = open(filename)
     text = fileobj.read()
     fileobj.close()