- 03 Dec, 2021 1 commit
-
-
Takuto Ikuta authored
Fixed: 1254615 Change-Id: Ic6d5350c7a89a597c1126ec05235a3e63eb2ad09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3312231 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com> Reviewed-by:
Anthony Polito <apolito@google.com>
-
- 22 Nov, 2021 1 commit
-
-
Josip Sokcevic authored
And run it in presubmit checks R=gavinmak@google.com Change-Id: If2a8848f6ce85c466f45d9bf0f4fca6b4d75312f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3296677Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 19 Nov, 2021 2 commits
-
-
Josip Sokcevic authored
And run it in presubmit checks R=apolito@google.com Change-Id: I1521fe4dd9fd5fe391459a00a91f03399b15b36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292211 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Josip Sokcevic authored
R=apolito@google.com Change-Id: I24610ca05536b4ac6eed2c0a33ef411650b46dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292089Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 18 Nov, 2021 1 commit
-
-
Anthony Polito authored
Change-Id: I51aece95bed6d32faf6f3f93591a7bdf459b3edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3291901 Auto-Submit: Anthony Polito <apolito@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 11 Nov, 2021 1 commit
-
-
Josip Sokcevic authored
User may have set fetch only on the old default branch. This ensures that fetch works with new default branch. R=gavinmak@google.com Bug: 1268775 Change-Id: I971cdd041e8e8a7f06a20f4de348c1395c7b6e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3274108 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
- 09 Nov, 2021 1 commit
-
-
Josip Sokcevic authored
Those comments are from bots and not useful when running git cl comments. R=ajp@google.com Fixed: 1266986 Change-Id: I6a8f8f81e02e4b4624027c4c95546bf5e3e7244b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3268350 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Andy Perelson <ajp@chromium.org> Reviewed-by:
Andy Perelson <ajp@chromium.org>
-
- 11 Oct, 2021 2 commits
-
-
Josip Sokcevic authored
This change starts observers as soon as possible, and wraps the entire block that can cause an exception in try..finally. This ensures that we stop threads are stopped. If we notice the same behavior, it could be worth to put a cap on number of executions per observer, and shut the thread down once reached. R=apolito@google.com Bug: 1255228 Change-Id: I1f165267460da02b3bbba39022c262e6c29fe86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3213451Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Josip Sokcevic authored
Only usage was in v8, and that was removed in 2016: http://crrev/45ec73da150e02fac1fc1dc15e3f14cb5bc2b45f R=tandrii@chromium.org Change-Id: I6aebcf1fc0cc29440b0b9c9b45d4e3fc35a38e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3214209Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 06 Oct, 2021 1 commit
-
-
Ben Pastene authored
And add a hook for it in the gerrit recipe_module. This will allow invocations of gerrit_client to set votes like "code-review-1" or "commit-queue+1" on CLs. This will be used by bots to control CLs they just created with update_files(). Bug: 1250084 Change-Id: I888458983165fed5882e5c37cba4a69dbfb9b810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3207266 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 05 Oct, 2021 1 commit
-
-
Josip Sokcevic authored
my_activity.py talks to third party (e.g. review.coreboot.org). Without certifi package, making https connection may result in CERTIFICATE_VERIFY_FAILED. Adding certifi package to .vpython (py2) doesn't work, so this change drops py2 support for my_activity.py. R=gavinmak@google.com Fixed: 1255921 Change-Id: I515b14c81d37a52d482d08085d8029c791911ae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3206906 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 28 Sep, 2021 1 commit
-
-
Gavin Mak authored
This reverts commit eff810e9. Reason for revert: breaks workflows for users Original change's description: > Error out of rebase-update if there are uncommitted changes > > Currently, running rebase-update may lead to missing untracked files. > This change prints an error instead freezing and thawing local changes. > > Bug: 1251047 > Change-Id: Ia5f718ed957dae936d2ead2778760ae0c8d9f9ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3171828 > Commit-Queue: Gavin Mak <gavinmak@google.com> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Bug: 1251047 Change-Id: I5b61dc1c7af13ccca6ea80baecff0522291083c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3191674 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
- 22 Sep, 2021 1 commit
-
-
Gavin Mak authored
Currently, running rebase-update may lead to missing untracked files. This change prints an error instead freezing and thawing local changes. Bug: 1251047 Change-Id: Ia5f718ed957dae936d2ead2778760ae0c8d9f9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3171828 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 20 Sep, 2021 1 commit
-
-
Josip Sokcevic authored
R=gavinmak@google.com Bug: 585752 Change-Id: I25ece89abd09ad509807a7db0403bac0f5ebdd4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3171825 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
- 17 Sep, 2021 1 commit
-
-
Josip Sokcevic authored
This is a partial reland of commit e8ef6259, but without actually upgrading gsutil. This refactoring allows easier upgrade of gsutil. R=dpranke@google.com Bug: 1249003 Change-Id: I63433b411e640a9fdb455ce25a51d910be0818a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3166676Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 09 Sep, 2021 1 commit
-
-
Josip Sokcevic authored
If remote HEAD returns legacy default branch, refresh HEAD by running set-head to check if there are any changes. R=gavinmak@google.com Change-Id: I5891a899b512e81fccfb086a056d497c906df4b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3152593 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
- 17 Aug, 2021 1 commit
-
-
Josip Sokcevic authored
This reverts commit e8ef6259. Reason for revert: https://crbug.com/1240673 High rate of bot_update failures, lots of gsutil defunct processes. Original change's description: > Update gsutil to use gsutil version 4.66, python3 > > This is a reland of 45773602 > with following changes: > * bump version from 4.61 to 4.66, which contains several bugfixes > > Original change's description: > > Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" > > > > This is a reland of e53a5939 > > > > Additional bug fixes: > > * handle race condition in gsutil when creating its directory > > * limit to one gsutil process on darwin due to bug in python3 > > > > Original change's description: > > > Reland "Update gsutil to use gsutil version 4.61, python3." > > > > > > This reverts commit af121aee. > > > > > > Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. > > > > > > Original change's description: > > > > Revert "Update gsutil to use gsutil version 4.61, python3." > > > > > > > > This reverts commit f059ec93. > > > > > > > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > > > > > > > Original change's description: > > > > > Update gsutil to use gsutil version 4.61, python3. > > > > > > > > > > This CL updates the gsutil.py wrapper to download and use > > > > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > > > > > > > v4.61 appears to be fully self-contained and have all of the > > > > > packages it needs vendored into it. So, there's no reason to > > > > > use vpython anymore, and this CL removes that. > > > > > > > > > > Also, this CL removes the 'fallback' option to gsutil and > > > > > the ability to force a version switch, as this should no > > > > > longer be necessary (it was added for a migration back in 2014 > > > > > but apparently this code was never removed afterwards). > > > > > > > > > > This CL also updates download_from_google_storage.py and > > > > > upload_to_google_storage.py to similarly not have the version flags > > > > > and to just use regular python3, not vpython3. > > > > > > > > > > Bug: 1184108 > > > > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > > > > > Bug: 1184108 > > > > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > > > Bug: 1184108 > > > Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155 > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Bug: 1184108 > > Change-Id: Ibb5d886fd22e3553521ff8ad6e2b4435844ef972 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2988716 > > Reviewed-by: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > > Bug: 1184108 > Change-Id: I33787dc75f6e45d6b462706e934d7a2a37703fa7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3088085 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 1184108, 1240673 Change-Id: I74c3243ea29b99476e09b6ddb49cb052812a1e3e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3100348 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
- 16 Aug, 2021 1 commit
-
-
Josip Sokcevic authored
This is a reland of 45773602 with following changes: * bump version from 4.61 to 4.66, which contains several bugfixes Original change's description: > Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" > > This is a reland of e53a5939 > > Additional bug fixes: > * handle race condition in gsutil when creating its directory > * limit to one gsutil process on darwin due to bug in python3 > > Original change's description: > > Reland "Update gsutil to use gsutil version 4.61, python3." > > > > This reverts commit af121aee. > > > > Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. > > > > Original change's description: > > > Revert "Update gsutil to use gsutil version 4.61, python3." > > > > > > This reverts commit f059ec93. > > > > > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > > > > > Original change's description: > > > > Update gsutil to use gsutil version 4.61, python3. > > > > > > > > This CL updates the gsutil.py wrapper to download and use > > > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > > > > > v4.61 appears to be fully self-contained and have all of the > > > > packages it needs vendored into it. So, there's no reason to > > > > use vpython anymore, and this CL removes that. > > > > > > > > Also, this CL removes the 'fallback' option to gsutil and > > > > the ability to force a version switch, as this should no > > > > longer be necessary (it was added for a migration back in 2014 > > > > but apparently this code was never removed afterwards). > > > > > > > > This CL also updates download_from_google_storage.py and > > > > upload_to_google_storage.py to similarly not have the version flags > > > > and to just use regular python3, not vpython3. > > > > > > > > Bug: 1184108 > > > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > > > Bug: 1184108 > > > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Bug: 1184108 > > Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155 > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: Ibb5d886fd22e3553521ff8ad6e2b4435844ef972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2988716 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 1184108 Change-Id: I33787dc75f6e45d6b462706e934d7a2a37703fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3088085Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 13 Aug, 2021 1 commit
-
-
Josip Sokcevic authored
R=apolito@google.com Bug: 1098562 Change-Id: I98123cba5b6a2ff077a5a599c8640e18de3c4957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3095027 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Anthony Polito <apolito@google.com> Reviewed-by:
Anthony Polito <apolito@google.com>
-
- 05 Aug, 2021 1 commit
-
-
Josip Sokcevic authored
Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I89008bc07b1c3de13d9c6dd64e723fe6dc8d01d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3015262 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
Anthony Polito <apolito@google.com>
-
- 28 Jul, 2021 1 commit
-
-
Xinan Lin authored
Following comment in crrev.com/c/3039331, submit call is fully synchronous. BUG=1207955 TEST=e2e Change-Id: I9146d43b4d4530ad5064709e418d34e3229e19ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3049672 Commit-Queue: Xinan Lin <linxinan@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
- 16 Jul, 2021 1 commit
-
-
Josip Sokcevic authored
This reverts commit 934ac6eb. Reason for revert: https://crbug.com/1225658, git reparent-branch may result in data loss (recoverable if gc doesn't remove it). Original change's description: > [depot_tools] Add --fork-point when computing merge-base > > Using --fork-point when possible reduces the number of merge conflicts when running merge-base. > > Bug: 1111269 > Change-Id: I7240fdc9a613d2eb4e856b5677fc713551d7afe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2519729 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Gavin Mak <gavinmak@google.com> R=gavinmak@google.com Bug: 1111269 Bug: 1225658 Change-Id: I2aeadeb2fbff18abcab5552e07254dfc1c2499a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3034831 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
- 15 Jul, 2021 1 commit
-
-
Josip Sokcevic authored
If user enters buganizer bug prefixed with b/, warn user that b: is expected. R=apolito@google.com Bug: 1226474 Change-Id: Ifbced843f9eecc00560cc273ae06bff9d435a815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3016587Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com>
-
- 13 Jul, 2021 1 commit
-
-
Josip Sokcevic authored
R=apolito@google.com Change-Id: I6a2ed557b9e8d45194b2fe4ea5327ce62020733c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3000134Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 12 Jul, 2021 1 commit
-
-
Josip Sokcevic authored
This reverts commit 45773602. Reason for revert: crbug/1227849 - android builders aren't happy, also a report from user about android not working properly. Original change's description: > Reland "Reland "Update gsutil to use gsutil version 4.61, python3."" > > This is a reland of e53a5939 > > Additional bug fixes: > * handle race condition in gsutil when creating its directory > * limit to one gsutil process on darwin due to bug in python3 > > Original change's description: > > Reland "Update gsutil to use gsutil version 4.61, python3." > > > > This reverts commit af121aee. > > > > Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. > > > > Original change's description: > > > Revert "Update gsutil to use gsutil version 4.61, python3." > > > > > > This reverts commit f059ec93. > > > > > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > > > > > Original change's description: > > > > Update gsutil to use gsutil version 4.61, python3. > > > > > > > > This CL updates the gsutil.py wrapper to download and use > > > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > > > > > v4.61 appears to be fully self-contained and have all of the > > > > packages it needs vendored into it. So, there's no reason to > > > > use vpython anymore, and this CL removes that. > > > > > > > > Also, this CL removes the 'fallback' option to gsutil and > > > > the ability to force a version switch, as this should no > > > > longer be necessary (it was added for a migration back in 2014 > > > > but apparently this code was never removed afterwards). > > > > > > > > This CL also updates download_from_google_storage.py and > > > > upload_to_google_storage.py to similarly not have the version flags > > > > and to just use regular python3, not vpython3. > > > > > > > > Bug: 1184108 > > > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > > > Bug: 1184108 > > > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Bug: 1184108 > > Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155 > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: Ibb5d886fd22e3553521ff8ad6e2b4435844ef972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2988716 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 1184108 Bug: 1227849 Change-Id: Ib4176b94861e9f85caf6ed74050111a07b1e308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3021641Reviewed-by:
Dirk Pranke <dpranke@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 09 Jul, 2021 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: If06db13e41a07786aa5a244e95aa3911d9367d6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3010275 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 08 Jul, 2021 1 commit
-
-
Josip Sokcevic authored
depot_tools supports extracting information from branch name. E.g. if branch contains fix-\d or bug-\d, commit description will contains appropriate git footers. However, such behavior should happen only on initial CL upload. Should user decide to delete such footer, we shouldn't set bug / fix on any following PS. R=ehmaldonado@chromium.org Bug: 1225663 Change-Id: I66adfdca070083ab66727d132919d47feb7ddd43 Fixed: 1225663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3010709 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Andy Perelson <ajp@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 30 Jun, 2021 2 commits
-
-
Peter Wen authored
This allows us to migrate PRESUBMIT.py files over to pylint-2.6 bit by bit. It also allows us to support and upgrade pylint to newer versions in the future. Bug: 1221143 Fixed: 1221143 Change-Id: I9af96f5f06caf48e9923ad5fae75b98a0a7aeb49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2994723 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
Sigurd Schneider authored
In the previous commit https://crrev.com/c/2532835 the option to order branches by date was added. This CL adds a git config variable cl.date-order than can be set to achive the same effect. Change-Id: Iaf24c46c5f7b63b1e518c18aedc455808a2dc752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2992887Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
-
- 28 Jun, 2021 1 commit
-
-
Josip Sokcevic authored
This is a reland of e53a5939 Additional bug fixes: * handle race condition in gsutil when creating its directory * limit to one gsutil process on darwin due to bug in python3 Original change's description: > Reland "Update gsutil to use gsutil version 4.61, python3." > > This reverts commit af121aee. > > Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. > > Original change's description: > > Revert "Update gsutil to use gsutil version 4.61, python3." > > > > This reverts commit f059ec93. > > > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > > > Original change's description: > > > Update gsutil to use gsutil version 4.61, python3. > > > > > > This CL updates the gsutil.py wrapper to download and use > > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > > > v4.61 appears to be fully self-contained and have all of the > > > packages it needs vendored into it. So, there's no reason to > > > use vpython anymore, and this CL removes that. > > > > > > Also, this CL removes the 'fallback' option to gsutil and > > > the ability to force a version switch, as this should no > > > longer be necessary (it was added for a migration back in 2014 > > > but apparently this code was never removed afterwards). > > > > > > This CL also updates download_from_google_storage.py and > > > upload_to_google_storage.py to similarly not have the version flags > > > and to just use regular python3, not vpython3. > > > > > > Bug: 1184108 > > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Bug: 1184108 > > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1184108 Change-Id: Ibb5d886fd22e3553521ff8ad6e2b4435844ef972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2988716Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 25 Jun, 2021 1 commit
-
-
Dirk Pranke authored
This CL adds a new field to the codereview.settings file used by git_cl for project-wide defaults. If `USE_PYTHON3` is set to True, then we will run the PRESUBMIT checks under Python3 by default instead of Python2, unless the PRESUBMIT.py file contains `USE_PYTHON3 = False` on a line by itself (as opposed to now, where we'll use Python2 by default unless the file contains `USE_PYTHON3 = True`). This will allow us have Python3 be the default for new files and to eventually eliminate any uses of `USE_PYTHON3` from the individual presubmit files. Of course, you will have to go in and explicitly add `USE_PYTHON3 = False` to any Py2-only files prior to enabling this. Bug: 1207012 Change-Id: Id8ec45b43940e5bcffeee196398c711c541e733e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2917747Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
- 23 Jun, 2021 1 commit
-
-
Song Fangzhen authored
This change updates the output format of `git cl split` when `description_file` has no footers. Bug: 1215852 Change-Id: I69764885337ec31134f2b5e2d861930e0bc8cd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2936161Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Fangzhen Song <songfangzhen@bytedance.com>
-
- 14 Jun, 2021 1 commit
-
-
Greg Guterman authored
Quick run is only set when the -q flag is passed. It is not set to 0 by other flags because only Chromium has Quick run and there are other depot_tools users. We rely on the CQ to set the flag back to 0. Bug: 1192827 Change-Id: I3310c9f005343f7d3eea56eaad5f19c7ba751921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2927818 Commit-Queue: Gregory Guterman <guterman@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 11 Jun, 2021 1 commit
-
-
Dirk Pranke authored
This reverts commit e53a5939. Reason for revert: Speculative revert for build failures on Mac11 bots: crbug.com/1219065. Original change's description: > Reland "Update gsutil to use gsutil version 4.61, python3." > > This reverts commit af121aee. > > Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. > > Original change's description: > > Revert "Update gsutil to use gsutil version 4.61, python3." > > > > This reverts commit f059ec93. > > > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > > > Original change's description: > > > Update gsutil to use gsutil version 4.61, python3. > > > > > > This CL updates the gsutil.py wrapper to download and use > > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > > > v4.61 appears to be fully self-contained and have all of the > > > packages it needs vendored into it. So, there's no reason to > > > use vpython anymore, and this CL removes that. > > > > > > Also, this CL removes the 'fallback' option to gsutil and > > > the ability to force a version switch, as this should no > > > longer be necessary (it was added for a migration back in 2014 > > > but apparently this code was never removed afterwards). > > > > > > This CL also updates download_from_google_storage.py and > > > upload_to_google_storage.py to similarly not have the version flags > > > and to just use regular python3, not vpython3. > > > > > > Bug: 1184108 > > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > > > Bug: 1184108 > > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1184108 Change-Id: Ib0757e0873d6e6b39621d50d327d959f0fa43720 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2957473 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
- 10 Jun, 2021 1 commit
-
-
Dirk Pranke authored
This reverts commit af121aee. Reason for revert: re-landing with a switch back to vpython to get the compiled C extension version of crcmod for performance. Original change's description: > Revert "Update gsutil to use gsutil version 4.61, python3." > > This reverts commit f059ec93. > > Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. > > Original change's description: > > Update gsutil to use gsutil version 4.61, python3. > > > > This CL updates the gsutil.py wrapper to download and use > > v4.61 of GCP's gsutil, which is Python3-compatible. > > > > v4.61 appears to be fully self-contained and have all of the > > packages it needs vendored into it. So, there's no reason to > > use vpython anymore, and this CL removes that. > > > > Also, this CL removes the 'fallback' option to gsutil and > > the ability to force a version switch, as this should no > > longer be necessary (it was added for a migration back in 2014 > > but apparently this code was never removed afterwards). > > > > This CL also updates download_from_google_storage.py and > > upload_to_google_storage.py to similarly not have the version flags > > and to just use regular python3, not vpython3. > > > > Bug: 1184108 > > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > > Reviewed-by: Mike Frysinger <vapier@chromium.org> > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Bug: 1184108 > Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1184108 Change-Id: I5d6d6d06842e08517488471c144972818fcf02ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2907155Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
- 03 Jun, 2021 2 commits
-
-
Edward Lesmes authored
If checked-out revision is less than 6 hours old, skip fetching latest revision. Bug: 1199853 Change-Id: Ifd2a61055de286fe6fd94a5d43f80a1885a6931c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911015Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Marco Georgaklis authored
The endpoint documentation can be found here: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-related-changes This involved adding support for the command in gerrit_client and gerrit_util and then incorporating functionality and testing into the gerrit recipe module. The reasoning for this is to be able to identify chained builds for improved accuracy of the new test identification for the FLake Endorser project. Bug:1204163 Change-Id: Ic60c733540a9afd7ff159408b0ea9ad7aac078e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928016 Commit-Queue: Marco Georgaklis <mgeorgaklis@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 26 May, 2021 1 commit
-
-
Edward Lesmes authored
This is a reland of 856ccef0 Use a tempfile instead of stdout for gclient revinfo output Original change's description: > bot_update: Don't use gclient sync output and rely on gclient revinfo. > > In preparation for skipping gclient sync if there are no DEPS changes. > > Bug: 1199853 > Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1199853 Change-Id: Ib50c4e943cbb51e4a2463beee9b7d1dee824ad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910950Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 24 May, 2021 2 commits
-
-
Stephen Martinis authored
This reverts commit 856ccef0. Reason for revert: Probably broke chrome os waterfall Original change's description: > bot_update: Don't use gclient sync output and rely on gclient revinfo. > > In preparation for skipping gclient sync if there are no DEPS changes. > > Bug: 1199853 > Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1199853 Change-Id: Ib893704dffc68b02dfa7f977e751e236003b7e0b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910949 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Owners-Override: Avi Drissman <avi@chromium.org>
-
Edward Lesmes authored
In preparation for skipping gclient sync if there are no DEPS changes. Bug: 1199853 Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-