Commit 26bfecdd authored by Takuto Ikuta's avatar Takuto Ikuta Committed by LUCI CQ

include filename in LUCI config validation

Fixed: 1254615
Change-Id: Ic6d5350c7a89a597c1126ec05235a3e63eb2ad09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3312231
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: 's avatarAnthony Polito <apolito@google.com>
parent 18785bb2
......@@ -1739,7 +1739,9 @@ def CheckChangedLUCIConfigs(input_api, output_api):
out_f = output_api.PresubmitError
else:
out_f = output_api.PresubmitNotifyResult
outputs.append(out_f('Config validation: %s' % msg['text']))
outputs.append(
out_f('Config validation for %s: %s' % ([str(obj['path'])
for obj in f], msg['text'])))
return outputs
......
......@@ -2019,6 +2019,8 @@ class CannedChecksUnittest(PresubmitTestsBase):
results = presubmit_canned_checks.CheckChangedLUCIConfigs(
input_api, presubmit.OutputApi)
self.assertEqual(len(results), 1)
self.assertEqual(results[0].json_format()['message'],
"Config validation for ['foo.cfg', 'bar.cfg']: deadbeef")
def testCannedCheckChangeHasNoTabs(self):
self.ContentTest(presubmit_canned_checks.CheckChangeHasNoTabs,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment