Remove unused variables

R=apolito@google.com

Bug: 1098562
Change-Id: I98123cba5b6a2ff077a5a599c8640e18de3c4957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3095027
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>

presubmit_support.py

@@ -565,46 +565,6 @@ class InputApi(object):
       r'.+\.patch$',
   )
 
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @property
-  def DEFAULT_WHITE_LIST(self):
-    return self.DEFAULT_FILES_TO_CHECK
-
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @DEFAULT_WHITE_LIST.setter
-  def DEFAULT_WHITE_LIST(self, value):
-    self.DEFAULT_FILES_TO_CHECK = value
-
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @property
-  def DEFAULT_ALLOW_LIST(self):
-    return self.DEFAULT_FILES_TO_CHECK
-
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @DEFAULT_ALLOW_LIST.setter
-  def DEFAULT_ALLOW_LIST(self, value):
-    self.DEFAULT_FILES_TO_CHECK = value
-
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @property
-  def DEFAULT_BLACK_LIST(self):
-    return self.DEFAULT_FILES_TO_SKIP
-
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @DEFAULT_BLACK_LIST.setter
-  def DEFAULT_BLACK_LIST(self, value):
-    self.DEFAULT_FILES_TO_SKIP = value
-
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @property
-  def DEFAULT_BLOCK_LIST(self):
-    return self.DEFAULT_FILES_TO_SKIP
-
-  # TODO(https://crbug.com/1098562): Remove once no longer used
-  @DEFAULT_BLOCK_LIST.setter
-  def DEFAULT_BLOCK_LIST(self, value):
-    self.DEFAULT_FILES_TO_SKIP = value
-
   def __init__(self, change, presubmit_path, is_committing,
       verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
     """Builds an InputApi object.

tests/presubmit_unittest.py

@@ -1453,42 +1453,11 @@ class InputApiUnittest(PresubmitTestsBase):
         self.fake_change, './PRESUBMIT.py', False, None, False)
     self.assertEqual(len(input_api.DEFAULT_FILES_TO_CHECK), 24)
     self.assertEqual(len(input_api.DEFAULT_FILES_TO_SKIP), 12)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_CHECK, input_api.DEFAULT_WHITE_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_CHECK, input_api.DEFAULT_ALLOW_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_SKIP, input_api.DEFAULT_BLACK_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_SKIP, input_api.DEFAULT_BLOCK_LIST)
 
     input_api.DEFAULT_FILES_TO_CHECK = (r'.+\.c$',)
     input_api.DEFAULT_FILES_TO_SKIP = (r'.+\.patch$', r'.+\.diff')
     self.assertEqual(len(input_api.DEFAULT_FILES_TO_CHECK), 1)
     self.assertEqual(len(input_api.DEFAULT_FILES_TO_SKIP), 2)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_CHECK, input_api.DEFAULT_WHITE_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_CHECK, input_api.DEFAULT_ALLOW_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_SKIP, input_api.DEFAULT_BLACK_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_SKIP, input_api.DEFAULT_BLOCK_LIST)
-
-    # Test backward compatiblity of setting old property names
-    # TODO(https://crbug.com/1098562): Remove once no longer used
-    input_api.DEFAULT_WHITE_LIST = ()
-    input_api.DEFAULT_BLACK_LIST = ()
-    self.assertEqual(len(input_api.DEFAULT_FILES_TO_CHECK), 0)
-    self.assertEqual(len(input_api.DEFAULT_FILES_TO_SKIP), 0)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_CHECK, input_api.DEFAULT_WHITE_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_CHECK, input_api.DEFAULT_ALLOW_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_SKIP, input_api.DEFAULT_BLACK_LIST)
-    self.assertEqual(
-        input_api.DEFAULT_FILES_TO_SKIP, input_api.DEFAULT_BLOCK_LIST)
 
   def testCustomFilter(self):
     def FilterSourceFile(affected_file):