- 05 Oct, 2011 1 commit
-
-
asvitkine@chromium.org authored
BUG=none TEST=Run unit tests - they should still pass. Run gcl try and git try and make sure there are no errors. Review URL: http://codereview.chromium.org/8133001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@104067 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Sep, 2011 2 commits
-
-
asvitkine@chromium.org authored
Needed to make it so changes containing only *.mm are only sent to Mac trybots by default. BUG=none TEST=none Review URL: http://codereview.chromium.org/8059009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102930 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Cause an infinite recursion in some context. TBR=asvitkine@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8036046 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102836 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Sep, 2011 2 commits
-
-
maruel@chromium.org authored
This was causing issues for windows user with notepad2. Fix trychange.py on python2.5. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8038028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102797 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Needed to make it so changes containing only *.mm are only sent to Mac trybots by default. BUG=none TEST=none Review URL: http://codereview.chromium.org/7925014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102783 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Sep, 2011 1 commit
-
-
jam@chromium.org authored
Fix gcl sometimes stripping the new line characters when changing the issue description on the server. This change replaces \n with \r\n before giving the description to the editor on Windows (not through cygwin though), and then replaces \r\n with \n when saving it locally or sending it to reitveld. BUG=95618 Review URL: http://codereview.chromium.org/7875004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101863 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Sep, 2011 2 commits
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7840038 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100172 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
Depends on extension mechanism for cpplint.py: http://codereview.appspot.com/4950069/ Pulls r74 of cpplint.py from: http://google-styleguide.googlecode.com/svn-history/r74/trunk/cpplint/cpplint.py Taken from WebKit's fork of cpplint.py. WebKit patch was: http://trac.webkit.org/changeset/46856 Credit Torch Mobile, Inc. who have contributed the WebKit patch in question. BUG=none TEST=Run gcl lint on a CL that has a Foo *bar style declaration. Review URL: http://codereview.chromium.org/7834045 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100151 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Jul, 2011 1 commit
-
-
maruel@chromium.org authored
It result in less code, forces uploading the change for eventual review and most importantly enables the commit queue to correctly handle this. BUG= TEST= Review URL: http://codereview.chromium.org/7253015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@91575 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jun, 2011 1 commit
-
-
maruel@chromium.org authored
presubmit_support.py can now creates a Rietveld object on its own. This is necessary since the object needs to be recreated out of process. The commit queue runs the presubmit check out of process for sanity reasons. Added TODO to push the cookie instead of the password. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7058054 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@87842 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 May, 2011 1 commit
-
-
maruel@chromium.org authored
That's just noise for the maintainer. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6985002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@84803 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81579 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
It's mostly to be used with the commit queue. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6820076 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81326 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Exposes InputApi.rietveld and deprecate host_url. This is useful since it places authentication at a single place. BUG= TEST= Review URL: http://codereview.chromium.org/6825008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81019 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Apr, 2011 3 commits
-
-
maruel@chromium.org authored
Make sure every site that catches gclient_utils.Error also catch subprocess2.CalledProcessError. BUG= TEST= Review URL: http://codereview.chromium.org/6691034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80339 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Otherwise I get useless stack traces and the user too. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6794020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80338 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6735029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80337 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6791018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80212 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Mar, 2011 2 commits
-
-
maruel@chromium.org authored
This reduces the likehood of conflict with local server and makes possible to run this check two times in parallel. R=dpranke@chromium.org TEST=moar unit tests BUG=none Review URL: http://codereview.chromium.org/6725042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79281 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
This fixes an issue where we would suggest '*' and then choke on the text down the road. Also, the suggestions were not yet very useful. R=maruel@chromium.org Review URL: http://codereview.chromium.org/6722014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79227 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Mar, 2011 1 commit
-
-
maruel@chromium.org authored
Reapply r79006 with fixes for ubuntu 10.4. The only change is in fix_default_encoding() to trap an exception locale.getlocale() may throw. R=dpranke@chromium.org BUG=none TEST=unit test Review URL: http://codereview.chromium.org/6721029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79144 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Mar, 2011 4 commits
-
-
maruel@chromium.org authored
It is causing exception for some users on ubuntu 10.4 with: "category LC_ALL is not supported" TBR=dpranke Review URL: http://codereview.chromium.org/6717025 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79012 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
With this code in action, I can successfully print arabic and chinese on linux and cygwin. It fails to print chinese on my Mac but prints arabic. It prints '?' on Windows console but it *doesn't throw* which is the biggest improvement here. It was particularly a problem on windows because WindowsError's description text is in the current ANSI code page so it failed to print if the text was not pure ASCII, like error message when using Windows' French UI. R=dpranke@chromium.org BUG=none TEST=manual unit test ./tests/fix_encoding_test.py and it shouldn't throw Review URL: http://codereview.chromium.org/6676090 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79006 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
TBR=maruel@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79005 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
The parsing of change descriptions had a lot of overlap and inconsistencies between gcl and git-cl. In particular, we weren't handling TBR= consistently, or probably a few other things. This change moves most of the code into presubmit_support and gclient_utils and just leaves the formatting differences for the messages between the two tools. Review URL: http://codereview.chromium.org/6719004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@79002 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Mar, 2011 4 commits
-
-
dpranke@chromium.org authored
output object, I forgot to modify the commit command, and so now we're ignoring failures complete. That's not good :( Landing w/o review (but with unit tests!) to minimize damage. Review URL: http://codereview.chromium.org/6688017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78627 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
R=chase@chromium.org,maruel@chromium.org Review URL: http://codereview.chromium.org/6674049 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78601 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
bugs that for some reason the presubmit missed the first time around. TBR=chase@chromium.org,maruel@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78497 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
Fix gcl to pass in the suggested owners properly in order to fix the bug introduced in r78329 (we were passing in a generator to the owners object and it needed to be a list). Fix a couple of other minor bugs related to suggesting reviewers while we're at it. R=chase@chromium.org,maruel@chromium.org Review URL: http://codereview.chromium.org/6673104 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78486 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Mar, 2011 5 commits
-
-
maruel@chromium.org authored
"Fix regression introduced in r78329." "Modify gcl to use suggested_reviewer output from presubmit_support." My quick fix was insufficient. TBR=dpranke Review URL: http://codereview.chromium.org/6667042 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78356 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This really needs a unit test. TBR=dpranke TEST=none Review URL: http://codereview.chromium.org/6670046 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78355 0039d316-1c4b-4281-b951-d872f2087c98
-
mhm@chromium.org authored
EDITOR environment variable shouldn't be required anymore can contain quotes and multiple arguments. Uses shell=True to let the shell parse the quoted string instead of handling all forms of quotes ourselves. By default, msysgit ships with the TERM environment variable set, when set to 'msys', we prepend 'env' to the executed command. That is required so msys knows which program to run the given file. BUG=none TEST=On many platforms. Win7, WinXP, Ubuntu. Review URL: http://codereview.chromium.org/6685062 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78332 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
Review URL: http://codereview.chromium.org/6696010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78329 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
This change moves the code I added to git-cl to parse the results of the presubmit hooks into presubmit_support itself. It also removes a lot of the text-file parsing that is no longer necessary since everything is in process. It also simplifies all of the PresubmitResult* objects and the way we're using output streams since we can assume more about how the callers are calling us. Note that I uses PEP-8 style method names where I was adding entirely new classes (or rewriting existing classes completely) since per maruel@ he is trying to new that style for new code. This change also contains two small changes to git_cl to fix bugs and restore the previous behavior of --force skipping the presubmit checks. Review URL: http://codereview.chromium.org/6694009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78328 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Mar, 2011 1 commit
-
-
bauerb@chromium.org authored
Original review: http://codereview.chromium.org/6650025/ BUG=none TEST=`git try foo` gives a proper error message. Review URL: http://codereview.chromium.org/6612036 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78180 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Mar, 2011 1 commit
-
-
thomasvl@chromium.org authored
something with spaces in it. BUG=none TEST=none Review URL: http://codereview.chromium.org/6686046 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@78027 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Mar, 2011 3 commits
-
-
mhm@chromium.org authored
BUG=70548 TEST=check $TERM in windows Review URL: http://codereview.chromium.org/6683035 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77978 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
It is cleaner this way since in Win32 console, the value is always "dumb" while in msysgit it is always "msys" The user shouldn't change the value of $TERM in msysgit otherwise their whole copy of msysgit will be flaky. BUG=70548 TEST=check $TERM in windows Review URL: http://codereview.chromium.org/6686027 TBR=mhm@chromium.org Review URL: http://codereview.chromium.org/6683033 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77972 0039d316-1c4b-4281-b951-d872f2087c98
-
mhm@chromium.org authored
It is cleaner this way since in Win32 console, the value is always "dumb" while in msysgit it is always "msys" The user shouldn't change the value of $TERM in msysgit otherwise their whole copy of msysgit will be flaky. BUG=70548 TEST=check $TERM in windows Review URL: http://codereview.chromium.org/6686027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77954 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Mar, 2011 1 commit
-
-
mhm@chromium.org authored
An explicit msysgit check is needed since it requires the usage of 'env' to open the editor. BUG=70550, 70548 TEST=Win,Linux Review URL: http://codereview.chromium.org/6680019 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77946 0039d316-1c4b-4281-b951-d872f2087c98
-