Special case when the change description has no footers, but looks
like a footer.

R=machenbach@chromium.org,andybons@chromium.org
BUG=579176

Review URL: https://codereview.chromium.org/1812803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299343 0039d316-1c4b-4281-b951-d872f2087c98

Depends on https://codereview.chromium.org/1755593003

BUG=591172

Review URL: https://codereview.chromium.org/1741983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299332 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=591172

Review URL: https://codereview.chromium.org/1805113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1777603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299312 0039d316-1c4b-4281-b951-d872f2087c98

R=andybons@chromium.org,jbudorick@chromium.org
BUG=579176

Review URL: https://codereview.chromium.org/1763153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299295 0039d316-1c4b-4281-b951-d872f2087c98

R=bauerb@chromium.org,ukai@chromium.org,andybons@chromium.org
BUG=579176,579160

Review URL: https://codereview.chromium.org/1799553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299293 0039d316-1c4b-4281-b951-d872f2087c98

Inspiration:
  $ watch -n 10 "git cl try-results"
  $ watch --color "ls -al --color"

R=nodir@chromium.org,sergiyb@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1799203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299291 0039d316-1c4b-4281-b951-d872f2087c98

Follow up on https://codereview.chromium.org/6758001

R=maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1795753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299283 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1798163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299278 0039d316-1c4b-4281-b951-d872f2087c98

BUG=437264

Review URL: https://codereview.chromium.org/1778243008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299267 0039d316-1c4b-4281-b951-d872f2087c98

BUG=437264

Review URL: https://codereview.chromium.org/1787633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299263 0039d316-1c4b-4281-b951-d872f2087c98

R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1789713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299261 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/1762513002/

Use gclient's git_cache setting in bot_update/api.py

BUG=589140
R=szager@chromium.org,iannucci@chromium.org

Review URL: https://codereview.chromium.org/1784043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299260 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1786883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299256 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1781083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299218 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1784623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299202 0039d316-1c4b-4281-b951-d872f2087c98

This is rolling in https://codereview.chromium.org/1777003003

BUG=593420

Review URL: https://codereview.chromium.org/1785443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299187 0039d316-1c4b-4281-b951-d872f2087c98

Apparently most Mac's have git 2.6.2, which doesn't have this
feature.

This only affects end developers, so there's no urgency to push
this out to the bots.

TBR=agable@chromium.org,wkorman@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/1777043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299185 0039d316-1c4b-4281-b951-d872f2087c98

I failed to do this in https://codereview.chromium.org/1706423002

BUG=495204

Review URL: https://codereview.chromium.org/1776283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299179 0039d316-1c4b-4281-b951-d872f2087c98

R=andybons@chromium.org,phajdan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1772293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299174 0039d316-1c4b-4281-b951-d872f2087c98

The key piece here is that when running 'git cl land' from a cache checkout, refs/pending/* must be fetched from / pushed to the cache mirror's remote.

BUG=589140
R=wkorman,agable,iannucci,martiniss

Review URL: https://codereview.chromium.org/1777693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299166 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Use gclient's git_cache setting in bot_update/api.py (patchset #6 id:100001 of https://codereview.chromium.org/1762513002/ )

Reason for revert:
Roll into build breaks infra crons.

Original issue's description:
> Use gclient's git_cache setting in bot_update/api.py
>
> BUG=589140
> R=agable@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299120

TBR=agable@chromium.org,hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,wkorman@chromium.org,szager@chromium.org
BUG=589140

Review URL: https://codereview.chromium.org/1776193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299160 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1771893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=585401

Review URL: https://codereview.chromium.org/1770383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299158 0039d316-1c4b-4281-b951-d872f2087c98

This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.

BUG=589140

Review URL: https://codereview.chromium.org/1768893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299143 0039d316-1c4b-4281-b951-d872f2087c98

git-cl-try does not properly print error message when the response
status code is 403, because response parsing is broken.
Fix response parsing.

R=sheyang@chromium.org, tandrii@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1773963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299137 0039d316-1c4b-4281-b951-d872f2087c98

BUG=589140
R=agable@chromium.org

Review URL: https://codereview.chromium.org/1762513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299120 0039d316-1c4b-4281-b951-d872f2087c98

BUG=579176

Review URL: https://codereview.chromium.org/1760063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299117 0039d316-1c4b-4281-b951-d872f2087c98

TBR=phajdan.jr@chromium.org,andybons@chromium.org
BUG=579176

Review URL: https://codereview.chromium.org/1762343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299110 0039d316-1c4b-4281-b951-d872f2087c98

BUG=579183

Review URL: https://codereview.chromium.org/1763593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299107 0039d316-1c4b-4281-b951-d872f2087c98

TBR=phajdan.jr@chromium.org,andybons@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1768583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=579183

Review URL: https://codereview.chromium.org/1761743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299105 0039d316-1c4b-4281-b951-d872f2087c98

Corresponding build CL: https://codereview.chromium.org/1759553007,
land OR revert both Cls in tandem.

TBR=phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1763013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=579176

Review URL: https://codereview.chromium.org/1764453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299095 0039d316-1c4b-4281-b951-d872f2087c98

This allows to generate new IDs on the fly without installing
commit-msg hook and works just fine on Windows.

BUG=579183

Review URL: https://codereview.chromium.org/1757133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299094 0039d316-1c4b-4281-b951-d872f2087c98

This should insert the message according to Gerrit's own commit-msg
hook implementation.

BUG=579183

Review URL: https://codereview.chromium.org/1758943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299093 0039d316-1c4b-4281-b951-d872f2087c98

The part that runs dartfmt was relying on the part that runs (or not)
Clang to set the |env| local variable, which no longer happens after
https://codereview.chromium.org/1734863002, making `git cl format` fail
with:

Traceback (most recent call last):
  File "/usr/local/google/home/ppi/projects/depot_tools/git_cl.py", line 3957, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/ppi/projects/depot_tools/git_cl.py", line 3939, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/work/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/ppi/projects/depot_tools/git_cl.py", line 3837, in CMDformat
    stdout = RunCommand(command, cwd=top_dir, env=env)
UnboundLocalError: local variable 'env' referenced before assignment

It seems that we don't need to override env for dartfm anyway - the
clang part is doing this to put clang_format_tool in PATH.

This patch just drops env= from RunCommand for dartfmt.

Review URL: https://codereview.chromium.org/1760873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299072 0039d316-1c4b-4281-b951-d872f2087c98

R=jsbell@chromium.org,phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1764463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299068 0039d316-1c4b-4281-b951-d872f2087c98

R=
BUG=
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/1750213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299063 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/1749213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299057 0039d316-1c4b-4281-b951-d872f2087c98