1. 14 May, 2019 1 commit
  2. 08 Apr, 2019 1 commit
    • Raul Tambre's avatar
      Fix UTF-8 output in gclient_utils.CheckCallAndFilter · 1fb04630
      Raul Tambre authored
      Hooks for Electron output UTF-8 characters.
      Example error for when ":heavy_check_mark:" is output:
        File "/home/markus/depot_tools/metrics.py", line 266, in print_notice_and_exit
          yield
        File "/home/markus/depot_tools/gclient.py", line 3112, in <module>
          sys.exit(main(sys.argv[1:]))
        File "/home/markus/depot_tools/gclient.py", line 3098, in main
          return dispatcher.execute(OptionParser(), argv)
        File "/home/markus/depot_tools/subcommand.py", line 252, in execute
          return command(parser, args[1:])
        File "/home/markus/depot_tools/gclient.py", line 2677, in CMDsync
          ret = client.RunOnDeps('update', args)
        File "/home/markus/depot_tools/gclient.py", line 1746, in RunOnDeps
          self.RunHooksRecursively(self._options, pm)
        File "/home/markus/depot_tools/gclient.py", line 1052, in RunHooksRecursively
          hook.run()
        File "/home/markus/depot_tools/gclient.py", line 245, in run
          cmd, cwd=self.effective_cwd, always=self._verbose)
        File "/home/markus/depot_tools/gclient_utils.py", line 344, in CheckCallAndFilterAndHeader
          return CheckCallAndFilter(args, **kwargs)
        File "/home/markus/depot_tools/gclient_utils.py", line 576, in CheckCallAndFilter
          stdout.write(in_byte.decode())
        File "/usr/lib/python2.7/encodings/utf_8.py", line 16, in decode
          return codecs.utf_8_decode(input, errors, True)
      UnicodeDecodeError: 'utf8' codec can't decode byte 0xe2 in position 0: unexpected end of data
      
      This issue was introduced in CL:1524583.
      
      Bug: 942522
      Change-Id: I3c4355b925b34398c800d142f942531a829e0297
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1541334
      Auto-Submit: Raul Tambre <raul@tambre.ee>
      Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
      Commit-Queue: Raul Tambre <raul@tambre.ee>
      1fb04630
  3. 26 Mar, 2019 1 commit
  4. 19 Mar, 2019 1 commit
  5. 11 Mar, 2019 1 commit
    • Nico Weber's avatar
      Move gclient path access to separate module. · 09e0b38f
      Nico Weber authored
      gclient_utils.py is a kitchen sink and is for that reason expensive
      to import. Move the comparatively cheap and simple path routines
      to a new gclient_paths module and use that in gn.py, clang_format.py,
      dart_format.py.
      
      (To be able to move FindGclientRoot() to gclient_paths.py,
      make it use io.open() instead of FileRead(). FileRead() tries
      to paper over invalid utf-8, but that was added for presubmits,
      not for .gclient files, so this is hopefully fine.)
      
      Cuts gn.py overhead in half (on my Windows laptop from 0.6s to 0.25s,
      still high; on my Mac laptop from 0.1s to 0.05s), and probably helps
      the other two too.
      
      Completely remove PathDifference() since it's unused.
      
      Bug: 939959
      Change-Id: I6a70f6e4c16062b622fb2df8778e8a598d4cc956
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512058
      Commit-Queue: Nico Weber <thakis@chromium.org>
      Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      09e0b38f
  6. 20 Mar, 2018 1 commit
  7. 31 Jan, 2018 1 commit
  8. 20 Oct, 2017 1 commit
  9. 19 Oct, 2017 2 commits
  10. 09 Oct, 2017 1 commit
  11. 16 Aug, 2017 1 commit
  12. 14 Jun, 2017 1 commit
  13. 12 Jun, 2017 1 commit
  14. 23 May, 2017 3 commits
  15. 21 Jan, 2017 1 commit
    • Andrii Shyshkalov's avatar
      Fix git cl on windows for git-numberer repos. · 351c61da
      Andrii Shyshkalov authored
      Git cl decides if git-numberer is enabled on a repository by writing
      Gerrit's project.config from refs/meta/config into a tempfile, which is
      then queried using `git config -f tempfile --get ...`.  The file itself
      is only flushed, but not closed after writing because Python's
      tempfile.NamedTemporaryFile is deleted on closing. This worked fine on
      Linix/Mac, but not on Windows, where `git config` apparently doesn't see
      file or its contents.
      
      This CL rewrites the above using yet another contexmanager temp
      directory into which a file is written and closed before git config is
      ran.
      
      R=machenbach@chromium.org,grt@chromium.org
      BUG=683202
      
      Change-Id: I7974d66b1b2b0478ab4b6f7ac04e547a4981c46c
      Reviewed-on: https://chromium-review.googlesource.com/430719
      Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
      Reviewed-by: 's avatarVadim Shtayura <vadimsh@chromium.org>
      351c61da
  16. 16 Dec, 2016 1 commit
  17. 20 Oct, 2016 1 commit
  18. 11 Oct, 2016 2 commits
  19. 30 Aug, 2016 1 commit
  20. 25 Aug, 2016 1 commit
  21. 24 Aug, 2016 1 commit
  22. 09 Aug, 2016 1 commit
  23. 08 Jun, 2016 1 commit
    • hinoka's avatar
      Add resource locking in gclient · 885e5b1e
      hinoka authored
      There are entries in the DEPS file where two folders uses the same
      git URL (ie. freetype2).  This doesn't work well with git caches because
      each task will run on it's own and might try to clobber on top of each other.
      
      This adds another field in a WorkItem which is a list of resources.  When the
      work queue is flushed, it has to make sure that none of a newly added workitem
      has any resource conflicts.
      
      BUG=618124
      
      Review-Url: https://codereview.chromium.org/2049583003
      885e5b1e
  24. 20 Apr, 2016 1 commit
  25. 05 Jun, 2015 1 commit
  26. 03 Jun, 2015 1 commit
  27. 20 Apr, 2015 1 commit
  28. 23 Feb, 2015 1 commit
  29. 07 Jan, 2015 1 commit
  30. 25 Dec, 2014 1 commit
  31. 12 Nov, 2014 1 commit
  32. 05 Sep, 2014 1 commit
  33. 13 Aug, 2014 1 commit
  34. 06 Aug, 2014 1 commit
    • primiano@chromium.org's avatar
      Reland: Add --no-history option to fetch and gclient for shallow clones. · 5439ea59
      primiano@chromium.org authored
      Original CL: https://codereview.chromium.org/440263002/
      
      Many people* have complained on chromium-dev about the long times
      required to perform a full fetch over a DSL. This seems to be mostly
      due to the huge size of chromium's history (~9 GB). On the other side,
      not everybody is interested in downloading the full git history of
      the projects. The size of git packs required to fetch a working HEAD
      is one order of magnitude smaller (1.5 GB).
      This change makes it possible to perform a shallow fetch (in a way
      which is consistent with DEPS, leveraging git templates on clone),
      reducing fetch times by 80% for those not interested in the history.
      
      * See:
      [chromium-dev] "fetch chromium" keeps hanging/getting stuck on Windows 7
      [chromium-dev] Initial checkout with git taking long
      [chromium-dev] Trying to get latest source code fails when fetching
      [chromium-dev] Gclient sync takes too long
      
      BUG=228996
      TBR=iannucci@chromium.org,szager@chromium.org,wtc@chromium.org
      
      Review URL: https://codereview.chromium.org/440273002
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287793 0039d316-1c4b-4281-b951-d872f2087c98
      5439ea59
  35. 05 Aug, 2014 2 commits