Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 26 Sep, 2022 2 commits
  3. 21 Sep, 2022 1 commit
  5. 20 Sep, 2022 2 commits
  7. 16 Sep, 2022 3 commits
  9. 15 Sep, 2022 3 commits
    • Bruce Dawson's avatar
      Show PresubmitResult call stacks in verbose mode · dca14bc4
      Bruce Dawson authored 
      When a presubmit message, warning, or error strikes it is sometimes due
to a bug or weakness in the presubmit. Examining the presubmit or fixing
it can be important. However it can be hard to find the relevant code
(hint: many presubmits are in depot_tools/presubmit_canned_checks.py).

With this change you can just run the presubmits with -v -v (double
verbose) and a call stack will be recorded when each presubmit result
object is created. For instance:

  >git cl presubmit --force --files ash/public/cpp/app_list/vector_icons/google_black.icon -v -v

  ** Presubmit Messages: 1 **
  Trademarked images should not be added to the public repo. See crbug.com/944754
        ash/public/cpp/app_list/vector_icons/google_black.icon

  ***************
  Presubmit result call stack is:
    File "depot_tools/presubmit_support.py", line 2098, in <module>
      sys.exit(main())
    File "depot_tools/presubmit_support.py", line 2074, in main
      return DoPresubmitChecks(
    File "depot_tools/presubmit_support.py", line 1771, in DoPresubmitChecks
      results += executer.ExecPresubmitScript(presubmit_script, filename)
    File "depot_tools/presubmit_support.py", line 1612, in ExecPresubmitScript
      self._run_check_function(function_name, context, sink,
    File "depot_tools/presubmit_support.py", line 1653, in _run_check_function
      result = eval(function_name + '(*__args)', context)
    File "<string>", line 1, in <module>
    File "chromium/src/PRESUBMIT.py", line 2225, in CheckNoProductIconsAddedToPublicRepo
      message_type(
    File "depot_tools/presubmit_support.py", line 352, in __init__
      self._long_text += ' '.join(traceback.format_stack(None, 8))

This changes tracking down presubmits from a dark art to a trivial operation.

Bug: 1309977
Change-Id: Ia0a6adfbbab04041f97c56cd2064a1627e252561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3896076Reviewed-by: 's avatarDmitrii Kuragin <kuragin@chromium.org>
Commit-Queue: Dmitrii Kuragin <kuragin@chromium.org>
      dca14bc4
    • Fabrice de Gans's avatar
      [code-health] Run XML pretty_print.py with vpython3 · ecfab096
      Fabrice de Gans authored 
      Bug: 942720
Change-Id: I281a2e39efe653d37fb115bf99f7680b57073cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3900835
Commit-Queue: Fabrice de Gans <fdegans@chromium.org>
Auto-Submit: Fabrice de Gans <fdegans@chromium.org>
Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: 's avatarAravind Vasudevan <aravindvasudev@google.com>
      ecfab096
    • Bruce Dawson's avatar
      Support a tag to ignore long lines · 5e4d7498
      Bruce Dawson authored 
      Long lines in source files are bad, but sometimes unavoidable. Since
ignoring warnings is even worse than long lines it is wise to have a way
to disable the warning. This change adds support for a multi-language
tag that can be put in unavoidably long lines.

Bug: 1309977
Change-Id: I205086050b5aa5b4a02a651c06615c82ec0e1a38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3896084Reviewed-by: 's avatarDmitrii Kuragin <kuragin@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      5e4d7498
  11. 13 Sep, 2022 2 commits
  13. 10 Sep, 2022 1 commit
  15. 09 Sep, 2022 5 commits
  17. 08 Sep, 2022 4 commits
  19. 07 Sep, 2022 5 commits
  21. 06 Sep, 2022 4 commits
  23. 03 Sep, 2022 1 commit
  25. 02 Sep, 2022 4 commits
  27. 01 Sep, 2022 2 commits
  29. 31 Aug, 2022 1 commit