Remove recipe warnings due to python module.

The python module is deprecated in favor of using the step module with
an explicit python binary. Switching the code to use the step module and
remove DEPS on recipe_engine/python removes warnings when running recipe
tests in the repo.

Change-Id: If3c9d5d6aff5aab69898b535399accbef92f5c0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3880624
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>

recipes/recipe_modules/bot_update/__init__.py

@@ -14,7 +14,6 @@ DEPS = [
     'recipe_engine/path',
     'recipe_engine/platform',
     'recipe_engine/properties',
-    'recipe_engine/python',
     'recipe_engine/raw_io',
     'recipe_engine/runtime',
     'recipe_engine/step',

recipes/recipe_modules/gclient/__init__.py

@@ -9,7 +9,6 @@ DEPS = [
   'recipe_engine/path',
   'recipe_engine/platform',
   'recipe_engine/properties',
-  'recipe_engine/python',
   'recipe_engine/raw_io',
   'recipe_engine/step',
   'tryserver',

recipes/recipe_modules/git/__init__.py

@@ -8,7 +8,6 @@ DEPS = [
   'recipe_engine/path',
   'recipe_engine/platform',
   'recipe_engine/properties',
-  'recipe_engine/python',
   'recipe_engine/raw_io',
   'recipe_engine/step',
 ]

recipes/recipe_modules/git_cl/__init__.py

 PYTHON_VERSION_COMPATIBILITY = 'PY2+3'
 
 DEPS = [
-  'recipe_engine/context',
-  'recipe_engine/python',
-  'recipe_engine/raw_io',
+    'recipe_engine/context',
+    'recipe_engine/raw_io',
+    'recipe_engine/step',
 ]

recipes/recipe_modules/git_cl/api.py

@@ -16,10 +16,9 @@ class GitClApi(recipe_api.RecipeApi):
       name = name + ' (%s)' % kwargs.pop('suffix')
 
     my_loc = self.c.repo_location if self.c else None
+    cmd = ['vpython', self.repo_resource('git_cl.py'), subcmd] + args
     with self.m.context(cwd=self.m.context.cwd or my_loc):
-      return self.m.python(
-          name, self.repo_resource('git_cl.py'), [subcmd] + args,
-          venv=True, **kwargs)
+      return self.m.step(name, cmd, **kwargs)
 
   def get_description(self, patch_url=None, **kwargs):
     """DEPRECATED. Consider using gerrit.get_change_description instead."""

recipes/recipe_modules/gitiles/__init__.py

@@ -7,7 +7,6 @@ PYTHON_VERSION_COMPATIBILITY = 'PY2+3'
 DEPS = [
     'recipe_engine/json',
     'recipe_engine/path',
-    'recipe_engine/python',
     'recipe_engine/raw_io',
     'recipe_engine/step',
     'recipe_engine/url',

recipes/recipe_modules/presubmit/__init__.py

@@ -20,7 +20,6 @@ DEPS = [
   'recipe_engine/json',
   'recipe_engine/path',
   'recipe_engine/properties',
-  'recipe_engine/python',
   'recipe_engine/step',
   'recipe_engine/resultdb',
   'tryserver',

recipes/recipe_modules/presubmit/api.py

@@ -28,22 +28,18 @@ class PresubmitApi(recipe_api.RecipeApi):
   def __call__(self, *args, **kwargs):
     """Returns a presubmit step."""
 
-    kwargs['venv'] = True
     name = kwargs.pop('name', 'presubmit')
     with self.m.depot_tools.on_path():
-      presubmit_args = list(args) + [
-          '--json_output', self.m.json.output(),
-      ]
+      cmd = ['vpython', self.presubmit_support_path]
+      cmd.extend(args)
+      cmd.extend(['--json_output', self.m.json.output()])
       if self.m.resultdb.enabled:
         kwargs['wrapper'] = ('rdb', 'stream', '--')
-      step_data = self.m.python(
-          name, self.presubmit_support_path, presubmit_args, **kwargs)
+      step_data = self.m.step(name, cmd, **kwargs)
       output = step_data.json.output or {}
       if self.m.step.active_result.retcode != 0:
         return output
 
-      # Run with vpython3 directly
-      del (kwargs['venv'])
       presubmit_args = list(args) + [
           '--json_output',
           self.m.json.output(),

recipes/recipe_modules/tryserver/examples/full.py

@@ -12,7 +12,6 @@ DEPS = [
   'recipe_engine/path',
   'recipe_engine/platform',
   'recipe_engine/properties',
-  'recipe_engine/python',
   'recipe_engine/step',
   'tryserver',
 ]