Commit 787e71ac authored by Jamie Madill's avatar Jamie Madill Committed by LUCI CQ

Fix code check in upload to google storage.

The check was inverted, and was generating suprious error messages.

Bug: None
Change-Id: I139bb9e7d15e51fbec8c5703b26ed60e1ed1fab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3884910
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
parent 443f9851
......@@ -120,7 +120,7 @@ def _upload_worker(
if os.stat(filename).st_mode & stat.S_IEXEC:
code, _, err = gsutil.check_call_with_retries(
'setmeta', '-h', 'x-goog-meta-executable:1', file_url)
if not code:
if code != 0:
ret_codes.put(
(code,
'Encountered error on setting metadata on %s\n%s' %
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment