- 22 Mar, 2019 1 commit
-
-
Jonas Termansen authored
For instance, if the bug-prefix is set to "b/", git cl upload will offer a line with "Bug: b/", however it won't get stripped away if it's left blank, unlike the default "Bug:" line. This change fixes that inconsistency by also taking the bug-prefix into account when stripping. Change-Id: Ib6e4d18c1ff52ec77cd1422be15b1e6920332238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1528972Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jonas Termansen <sortie@google.com>
-
- 22 Feb, 2019 1 commit
-
-
Edward Lemur authored
Bug: 914655 Change-Id: I06a3ff39d884327fd407a5c50cc9730a375bef0b Reviewed-on: https://chromium-review.googlesource.com/c/1382974 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 20 Feb, 2019 1 commit
-
-
Quinten Yearsley authored
In particular, only show robot comments from the latest patchset. Bug: 924780 Change-Id: I12038ddd2d90a5cb561b248de3fd37908d5b927e Reviewed-on: https://chromium-review.googlesource.com/c/1457282Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 13 Dec, 2018 1 commit
-
-
Bryce Thomas authored
Commit a185e2e3 removed the Rietveld code review implementation, albeit hasn't expunged all references to Rietveld. This leads to an assertion error when running |git cl format| on a non-Gerrit change. There appears to have been a recent attempt to articulate this error better in a185e2e3, albeit not fix the underlying issue. This change addresses the immediate issue by defaulting the code review implementation to Gerrit rather than Reitveld. R=joenotcharles@google.com, tandrii@chromium.org Bug: 914150 Change-Id: I64d33e5a172cc43339ec417f7f0a7820e0337772 Reviewed-on: https://chromium-review.googlesource.com/c/1372928Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bryce Thomas <bryct@amazon.com>
-
- 05 Dec, 2018 1 commit
-
-
Edward Lemur authored
Bug: 877717 Change-Id: I6541a971068aae662b086eba84448bd0769f1a09 Reviewed-on: https://chromium-review.googlesource.com/c/1362405Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 01 Dec, 2018 1 commit
-
-
Edward Lemur authored
Bug: 770408 Change-Id: Ic5029d6b12cdb6ea30704d90229ab7e365dc7273 Reviewed-on: https://chromium-review.googlesource.com/c/1354384 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 21 Nov, 2018 2 commits
-
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I59859048d64902669479e666c6c3d37c1fb1394c Reviewed-on: https://chromium-review.googlesource.com/c/1344642 Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I9c9f5e0f8ef41c0f6a00faa67acf0cf516290f09 Reviewed-on: https://chromium-review.googlesource.com/c/1345272Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 03 Nov, 2018 1 commit
-
-
Edward Lemur authored
Bug: 897394 Change-Id: I07959e870fef4e6a6b8e6e7c974397d3306460c1 Reviewed-on: https://chromium-review.googlesource.com/c/1315839 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 30 Oct, 2018 2 commits
-
-
Andrii Shyshkalov authored
Except when TBR is active, because it's not clear how to compute max score for Code-Review label before uploading a change. Tested with this very own CL: To https://chromium.googlesource.com/chromium/tools/depot_tools.git * [new branch] c78de165c7be156bdf8032c0ce3d8bad42778f1c -> refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado, cc=ajp,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org, l=Commit-Queue+1,hashtag=git-cl-upload R=ehmaldonado Bug: 877717 Change-Id: I464d9df2814bd830dd608bb881040e2dd3c41dbb Reviewed-on: https://chromium-review.googlesource.com/c/1307052Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
For other hosts, behavior is not changed. Tested on this very CL: To https://chromium.googlesource.com/chromium/tools/depot_tools.git * [new branch] 9057c2235b096f1feae61d65569641fc7c08a0e2 -> refs/for/refs/heads/master%ready,notify=ALL,m=Initial_upload,r=ehmaldonado,cc=chromium-reviews@chromium.org,cc=iannucci+depot_tools@chromium.org,hashtag=git-cl-upload R=ehmaldonado Bug: 877717 Change-Id: I951fc576105211590c6c303ce0ed2fe142628224 Reviewed-on: https://chromium-review.googlesource.com/c/1307051Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 16 Oct, 2018 4 commits
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I94ff37f198937dc7d341a859a71becd91cf3a706 Reviewed-on: https://chromium-review.googlesource.com/c/1279140 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I211ad8e67e9486b974eed7694436afb15ecf21a2 Reviewed-on: https://chromium-review.googlesource.com/c/1279136 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: Ib3120b5fd09c35be691c025d0d69ceda60f2ec7f Reviewed-on: https://chromium-review.googlesource.com/c/1279135 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I980487aacd115535d0ca855cd1edfcfc18fc5cbe Reviewed-on: https://chromium-review.googlesource.com/c/1279138 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 15 Oct, 2018 6 commits
-
-
Andrii Shyshkalov authored
Also fix a typo in ValidateEmail function which didn't support email addresses with '-' in them, e.g., infra-dev@chromium.org. R=ehmaldonado Bug: 875089 Change-Id: I2d73c1473527c9bf62e25e9f88250196b783fcb0 Reviewed-on: https://chromium-review.googlesource.com/c/1242849 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
Also deletes lots of tests which provided coverage for Rietveld only, and hence no longer useful. R=ehmaldonado Bug: 770408 Change-Id: I31195f7819a52d1063ed28064a74fd70fbc39357 Reviewed-on: https://chromium-review.googlesource.com/c/1279133 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: Id070e6084b6beba7309bdc35f0f750decd77e0c9 Reviewed-on: https://chromium-review.googlesource.com/c/1279132 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 770408 Change-Id: I5020596ada0c6fef2797fed6b78e7256a35ffc40 Reviewed-on: https://chromium-review.googlesource.com/c/1279131 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Andrii Shyshkalov authored
This adds O(reviewers+cc) RPC to Gerrit before upload, though done concurrently in up to 10 threads. This information isn't used yet, but will be in follow up CLs. R=ehmaldonado Bug: 877717 Change-Id: I2374f249ee874a71089244309e50e8e88a3dee7d Reviewed-on: https://chromium-review.googlesource.com/c/1242847Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 877717 Change-Id: Iccfba594369d8c726fd9b077d3ac18046757e4a2 Reviewed-on: https://chromium-review.googlesource.com/c/1242845 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 05 Oct, 2018 1 commit
-
-
Eric Boren authored
Bug: skia:8394 Change-Id: I928eaec8459a5905360ce760c6361e4554852b44 Reviewed-on: https://chromium-review.googlesource.com/c/1261796Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
- 27 Sep, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=smut@google.com Bug: 881860 Change-Id: I59c337384891f02dbd2cc776318803ac556843ca Reviewed-on: https://chromium-review.googlesource.com/1247584Reviewed-by:
smut <smut@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 25 Sep, 2018 3 commits
-
-
Andrii Shyshkalov authored
This removes 1 RPC when tbr-ing second or later patchset. Since tests cover TBR only in first upload, there are no test changes. Since adding test is real PITA here, keep them as is. R=ehmaldonado Change-Id: I90801b06727ce2131a703d6cd6c24ffad798bc8a Reviewed-on: https://chromium-review.googlesource.com/1242212Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: Ie5522283e84bdec9d98e236577eaad568816519b Reviewed-on: https://chromium-review.googlesource.com/1242211Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This will cycle through known gerrit mirrors for chromium-review host if Gerrit HTTP RPC results in 404 after successful initial git push refs/for/refs/... Tested locally by intentionally using wrong change number (2000000): $ PATH=`pwd`:$PATH git cl upload --bypass-hooks ... remote: Processing changes: refs: 1, new: 1, done remote: SUCCESS remote: New Changes: remote: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1227440 * [new branch] ea9aea5faa85b4b289b7add4bc6f4d5dd6a01caf -> refs/for/refs/heads/master%wip,m=Initial_upload,hashtag=git-cl WARNING:root:404 NotFound error occurred while querying POST https://chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found WARNING:root:404 NotFound error occurred while querying POST https://ap1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found WARNING:root:404 NotFound error occurred while querying POST https://us1-mirror-chromium-review.googlesource.com/a/changes/chromium%2Ftools%2Fdepot_tools~2000000/revisions/current/review: Not Found ^C Bug: 881860 Change-Id: Iac7dbe4e35052007650a7a2646a394caed6bd400 Reviewed-on: https://chromium-review.googlesource.com/1227441 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 18 Sep, 2018 3 commits
-
-
Sergiy Byelozyorov authored
R=ehmaldonado@chromium.org, machenbach@chromium.org Bug: 878303 Change-Id: Ia90001025babe692e481eb74fdbb4a66ce9a22f8 Reviewed-on: https://chromium-review.googlesource.com/1230074 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Eric Boren authored
This reverts commit 18b4479c. Reason for revert: Breaking WebRTC roller: https://luci-milo.appspot.com/buildbot/client.webrtc.fyi/Auto-roll%20-%20WebRTC%20DEPS/12788 Original change's description: > gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator > > Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91 > Reviewed-on: https://chromium-review.googlesource.com/1221826 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> TBR=vadimsh@chromium.org,dnj@chromium.org,borenet@chromium.org,tandrii@chromium.org Change-Id: I93bbd2d09cd2b27d9a7aa98fc15d60c5033a38cd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1231433Reviewed-by:
Eric Boren <borenet@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
Eric Boren authored
Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91 Reviewed-on: https://chromium-review.googlesource.com/1221826Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
- 17 Sep, 2018 1 commit
-
-
Leszek Swirski authored
Print "git cl comments" json to stdout when the output file is "-" Change-Id: I91021317e52019a0d499cccc4f40f062127b300e Reviewed-on: https://chromium-review.googlesource.com/1228094 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 28 Aug, 2018 3 commits
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: Ibc631bf049440d158de757da0a225ed28f892891 Reviewed-on: https://chromium-review.googlesource.com/1194314Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: I218a8198d06e51ac2eb57636bbccca9aadc7d81a Reviewed-on: https://chromium-review.googlesource.com/1194312Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
* remove tests which weren't actually testing any new code path. * remove Rietveld tests, except 1. * change default to Gerrit. R=ehmaldonado Bug: 719954 Change-Id: I27e59036bbafb870cadc4d6208d21ba17c48c8c0 Reviewed-on: https://chromium-review.googlesource.com/1188992Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 25 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Bug: 876910 Change-Id: I258efa0a95f20b80819bc89cccfb5e0a29e09d5c Reviewed-on: https://chromium-review.googlesource.com/1188989 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 23 Aug, 2018 4 commits
-
-
Andrii Shyshkalov authored
This fixes Gerrit project detection based on remote URL, accounting for potential 'a/' prefix in the URL path component, which isn't part of the Gerrit project name. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I473ae8c6c9e0f2034b350901abd67db151e0a3d3 Reviewed-on: https://chromium-review.googlesource.com/1187573Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Broke release process. R=ehmaldonado, mmoss Bug: 876964, 876910 Change-Id: I02ea424632f5c5522af0010adce1c993e2610b48 Reviewed-on: https://chromium-review.googlesource.com/1187548Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
Sadly, this makes maintaining one test handling covering exceptional circumstance very complex, so it was removed. I've decoupled test that ensures that GetRemoteUrl works from upload codepath. R=ehmaldonado@chromium.org Bug: 876910 Change-Id: I39de410c72d893e73492d5c3fc8f60a6ebc4f11f Reviewed-on: https://chromium-review.googlesource.com/1186142Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ehmaldonado@chromium.org Testing patched my own depot_tools in $PATH and uploaded https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1186072 which set reviewers and ccs as expected. Bug: 876910 Change-Id: I43c0f2284941cf703133bb51132226d4a0472d8e Reviewed-on: https://chromium-review.googlesource.com/1186068 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 22 Aug, 2018 1 commit
-
-
Andrii Shyshkalov authored
R=ehmaldonado Change-Id: I5be27cb025f8237cef0186c90eb7b99d000076d9 Reviewed-on: https://chromium-review.googlesource.com/1185986 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 23 Jul, 2018 1 commit
-
-
Edward Lemur authored
Bug: 832386 Change-Id: Iccb71c020aea31db33fc16050cb1100ccf5a7fbb Reviewed-on: https://chromium-review.googlesource.com/1145902Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-