- 12 Oct, 2017 2 commits
-
-
Stefan Zager authored
R=agable@chromium.org,tandrii@chromium.org Bug: Change-Id: I7a5ec6ca1bb05d67b1ddbee60eac89d57464a480 Reviewed-on: https://chromium-review.googlesource.com/710007Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org>
-
Andrii Shyshkalov authored
Rietveld CQ has already been disabled and is no longer supoorted. TBR=iannucci@chromium.org No-Try: True Bug: 770592 Change-Id: I35b0c6c9da585519b9ad6df316709fb58b17b24f Reviewed-on: https://chromium-review.googlesource.com/714298Reviewed-by:
-
- 11 Oct, 2017 4 commits
-
-
Bruce Dawson authored
Sometimes it is necessary to recreate a VS toolchain package with a tiny change such as editing or removing a single file. Recreating the VS environment can be time consuming or even impossible (the VS installer does not allow going to arbitrary versions) so this switch allows repackaging an existing unpacked directory. The typical usage would be to make the modifications to one of the toolchain directories in depot_tools\win_toolchain\vs_files and then repackage it using: python package_from_installed.py --repackage third_party\depot_tools\win_toolchain\vs_files\9bc7ccbf9f4bd50d4a3bd185e8ca94ff1618de0b Bug: 772123 Change-Id: I77b928f695e5f07e33f68dd37711c8761a3c7a22 Reviewed-on: https://chromium-review.googlesource.com/713562Reviewed-by:Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/16a83eb5fd3d855a2bd41974fe7268d42fef3866 Update source_manifest (hinoka@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie0b9f4f84c0cb3644906890f938e2726b0a35b11 Reviewed-on: https://chromium-review.googlesource.com/714037Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Ryan Tseng authored
This reverts commit c3eb3fa3. Reason for revert: Broke everything, probably due to version pin mismatch somewhere (gclient/git_cache likely getting called across repo boundary) Original change's description: > git_cache: Remove locks > > These aren't in use, and the original problem they were > meant to solve has been solved at the gclient.py layer > using resource locking: > https://codereview.chromium.org/2049583003 > > Bug: 773008 > Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a > Reviewed-on: https://chromium-review.googlesource.com/707728 > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,agable@chromium.org,phajdan.jr@chromium.org Change-Id: Ia9061f0ac827599d81d7638f535f97e15efa75fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773008 Reviewed-on: https://chromium-review.googlesource.com/711055Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
Vadim Shtayura authored
This reverts commit c3eb3fa3. Reason for revert: lots of "runhooks" failure everywhere Example: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/92720 Original change's description: > git_cache: Remove locks > > These aren't in use, and the original problem they were > meant to solve has been solved at the gclient.py layer > using resource locking: > https://codereview.chromium.org/2049583003 > > Bug: 773008 > Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a > Reviewed-on: https://chromium-review.googlesource.com/707728 > Reviewed-by: Aaron Gable <agable@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Ryan Tseng <hinoka@chromium.org> TBR=iannucci@chromium.org,hinoka@chromium.org,agable@chromium.org,phajdan.jr@chromium.org Change-Id: I31d5fef94f39f3a9f97b9e59121073b1f433d11e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773008 Reviewed-on: https://chromium-review.googlesource.com/711054Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 10 Oct, 2017 8 commits
-
-
Ryan Tseng authored
These aren't in use, and the original problem they were meant to solve has been solved at the gclient.py layer using resource locking: https://codereview.chromium.org/2049583003 Bug: 773008 Change-Id: I6609f39d7f15604e0bb3d742a41c4f9fec87a57a Reviewed-on: https://chromium-review.googlesource.com/707728Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
Stefan Zager authored
Sometimes I want to get try bot results without checking out the relevant branch. R=agable@chromium.org Bug: Change-Id: I89d118962ee37b10d95cf4044b61a0f2234b7e60 Reviewed-on: https://chromium-review.googlesource.com/710500 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
-
Nico Weber authored
clang-cl relies on this env var being set for 2017 to find the linker. Bug: 772123 Change-Id: Id03896504d38dc706b2bd96a2c3834c6cb9db9fe TBR=brucedawson Reviewed-on: https://chromium-review.googlesource.com/709697 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org>
-
William Hesse authored
BUG=768318 R=phajdan.jr@chromium.org R=dnj@chromium.org R=iannucci@chromium.org Change-Id: I2c85f9d30e74cfaebf2718bee075d6a21a6e0421 Reviewed-on: https://chromium-review.googlesource.com/708738Reviewed-by:
Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Dan Jacques authored
Add CIPD manifest PRESUBMIT canned checks. BUG=None TEST=local Change-Id: Ibf739147f47b4f38a2892c856cf45c5839d1c3e7 Reviewed-on: https://chromium-review.googlesource.com/707557 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Dan Jacques authored
Bump CIPD client version to: c8044eb23015ef176913df6f4493c13f67e4d44b BUG=None TEST=staging - Deployed as staging on BuildBot instances. Change-Id: I234fc7a16b0bb259e41d28c01a3a7d611d361f81 Reviewed-on: https://chromium-review.googlesource.com/707939Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 772843 Change-Id: I994f829cba7577e6b628d36d894f4c5d1f3c429c Reviewed-on: https://chromium-review.googlesource.com/708656 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org>
-
Nico Weber authored
Apparently several scripts in other repros call this function directly. Bug: 772741 Change-Id: I486483e44a072af6cf8c75373a2da6ef5469fc2c TBR=dpranke Reviewed-on: https://chromium-review.googlesource.com/707937 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
- 09 Oct, 2017 3 commits
-
-
Nodir Turakulov authored
If -m option value starts with "luci.", most probably the user intends to schedule a build on a LUCI bucket. Print an error message asking the user to use -B option. Bug: 749696 Change-Id: If7a038a1f629ee808e3261ae1c753e388bfea893 Reviewed-on: https://chromium-review.googlesource.com/707534Reviewed-by:
-
Nico Weber authored
The script prints a bunch of stuff behind `if verbose` checks, but then "verbose" was turned on by default in https://bugs.chromium.org/p/chromium/issues/detail?id=504452 I think the wrong lesson was learned from that bug – it sounds like the problem was that an error message was printed only if verbose was set. After this change, the script is silent when it does nothing, and prints something if something happens. (Arguably, it still prints too much in the case where it successfully downloads something.) This is part of a few changes to make `gclient runhooks` less noisy. Bug: 772741,504452 Change-Id: I5823c296abe97611ba4411bab2743673b10dca4b Reviewed-on: https://chromium-review.googlesource.com/706915 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Nico Weber authored
The newline is probably here to protect against a hook that doesn't print a trailing newline. I've never seen a hook that did that, and if we found one, we could make the logic look like "print a trailing newline if it's not there" -- or just fix the hook. The newline has been around since depot_tools was created (https://codereview.chromium.org/92087, gclient.py), back then this was in a general "run stuff" function, not in hooks-specific code. Maybe it made more sense back then. This is part of a few changes to make `gclient runhooks` less noisy. Bug: 772741 Change-Id: I285f76dc3f01c5acf5bbaa0be4db9f6edb9c0366 Reviewed-on: https://chromium-review.googlesource.com/706914Reviewed-by:
-
- 08 Oct, 2017 1 commit
-
-
Dan Jacques authored
Update "google-compute-engine" and "boto" package versions. Newer "gsutil" versions expect a newer "google-compute-engine" package version, and fail with an ImportError on "constants.py". BUG=None TEST=prod - ssh into failing bot, ran with current "gsutil.vpython", reproduced. - ssh into failing bot, ran with new "gsutil.vpython", fixed. - ssh into old GCE image, ran with new "gsutil.vpython", works. Change-Id: Ied277b6dc1cda4bc46cc9d58a633620c055e9d7c Reviewed-on: https://chromium-review.googlesource.com/706807Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
- 06 Oct, 2017 2 commits
-
-
Dirk Pranke authored
R=smut@chromium.org TBR=phajdan.jr@chromium.org BUG=570091 Change-Id: I9e0cce71105e9b819019d64c8857c2e86796a16f Reviewed-on: https://chromium-review.googlesource.com/704224 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
smut <smut@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3e09a61a1ad7c8f21e2ce2afd7240855c318d7ce Update source_manifest to e8149bf in luci-go (hinoka@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibb352c4c937bd213567fa93820f13379e3f28790 Reviewed-on: https://chromium-review.googlesource.com/704134Reviewed-by:
-
- 05 Oct, 2017 1 commit
-
-
Xiaoyin Liu authored
For security and privacy, change http://www.chromium.org/developers/contributing-code link to use HTTPS. R=dpranke@chromium.org Bug: Change-Id: I12d0658631d7704de1b3072f6eb840814cc6bed0 Reviewed-on: https://chromium-review.googlesource.com/702034Reviewed-by:
-
- 04 Oct, 2017 6 commits
-
-
Dan Jacques authored
Roll CIPD version to: bbb30ff0932ace4c6bed7ca1ba14e8a1ccc819cb TBR=iannucci@chromium.org BUG=chromium:771277 TEST=canary Change-Id: I4fb064dcad7072a6a4f728f6c6384a8a65ad56a3 Reviewed-on: https://chromium-review.googlesource.com/701434Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I44da3366fe4aa91240f4b3076f53e27aa4a81806 Reviewed-on: https://chromium-review.googlesource.com/700498Reviewed-by:
-
Paweł Hajdan, Jr authored
See https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/687496 Bug: 570091 Change-Id: Ifb2c8473e1b1e8ae0c73365bc806a995ddbd7b74 Reviewed-on: https://chromium-review.googlesource.com/698066Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
-
Michael Moss authored
This is supported by gclient and has the effect of treating the solution as a purely local, standalone DEPS (i.e. not as a source repo to checkout or process in any way). It also prevents the solution from being added to the output of 'gclient flatten'. R=agable@chromium.org, phajdan.jr@chromium.org Change-Id: Ie11246ec7a74097b96ea6a26983a63b3fb3123a5 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build Reviewed-on: https://chromium-review.googlesource.com/698271 Commit-Queue: Michael Moss <mmoss@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4d872b88fb06006ec917c6d2a3324e26c0124319 Add 'service_account' recipe module. (vadimsh@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id3e9d6203bb5baf4ea26d9cdb1c42ccd356c223d Reviewed-on: https://chromium-review.googlesource.com/699814Reviewed-by:
-
Aaron Gable authored
Previously, git-cl-diff went through a dance where it would create a new branch, download the uploaded patch onto that branch, and then diff against that. This had all sorts of problems: if you aborted the command, it might leave you on that branch; if you have local changes, they might get clobbered or the command would refuse to run. Now that we're in a Gerrit-only world, and patchsets are by definition equivalent to commits, we can simply diff against whatever local commit was last uploaded or, in a pinch, fetch the uploaded commit and diff against that. Bug: 759893 Change-Id: Ia4b93dcfb9b8aba85817e62731f68d6450026e75 Reviewed-on: https://chromium-review.googlesource.com/639915Reviewed-by:
-
- 03 Oct, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 661382 Change-Id: Id50b2541132002452bc5d86bb013758e8be0f4b0 Reviewed-on: https://chromium-review.googlesource.com/697813Reviewed-by:
-
- 02 Oct, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I195f5f798d9869f385437db4e0bc5f4c5d4853ae Reviewed-on: https://chromium-review.googlesource.com/687496 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 661382 Change-Id: I0e74273a5e00b4f3cf1d5c22ce0944dc2fa6f31e Reviewed-on: https://chromium-review.googlesource.com/692934Reviewed-by:
-
Sigurdur Asgeirsson authored
Change-Id: Iacc2efd6974f1a161da6e33a0d25d6329fcaaf4f Reviewed-on: https://chromium-review.googlesource.com/692697 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org>
-
- 30 Sep, 2017 2 commits
-
-
Aaron Gable authored
This code appears unused, and if it is used, it isn't useful anymore. R=tandrii@chromium.org Bug: 770408 Change-Id: I8b96a119be8ed20132e0b7439e466ad90f3757c2 Reviewed-on: https://chromium-review.googlesource.com/693337Reviewed-by:
-
Aaron Gable authored
The command only supports rietveld; we use git drover for Gerrit. R=tandrii@chromium.org Bug: 770408 Change-Id: I63a32e6e355ab361a77fb1328c21934613602a27 Reviewed-on: https://chromium-review.googlesource.com/693339Reviewed-by:
-
- 29 Sep, 2017 5 commits
-
-
Eric Boren authored
Bug: Change-Id: Id5efd1e84318b95297c6d83f77e58f617d7db8de Reviewed-on: https://chromium-review.googlesource.com/690242 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Michael Moss authored
R=phajdan.jr@chromium.org Change-Id: I7313b8a26a5f2934e26491fc4b9403ba6cea0cee Reviewed-on: https://chromium-review.googlesource.com/691017Reviewed-by:
-
Bruce Dawson authored
This is the second attempt at fixing autoninja to allow passing '^^' to it to specify that ninja should build the outputs of the specified file instead of building that file itself. The problem is that '^' is a special character and when extra layers of indirection are added the number of '^' characters needed grows exponentially in some poorly understood way. The first fix attempt just quoted the arguments that autoninja.bat passed to autoninja.py, but that meant they came in as one argument. This fix expands on that by modifying autoninja.py to understand how to deal with the monolithic argument. With this change this once again works: autoninja -C out\debug_component ..\..\base\win\enum_variant.cc^^ It can be convenient to have a ninja.bat file which starts goma and lets users keep typing the same build commands. However even with this fix the previously recommended ninja.bat file must be invoked with four '^' characters. If that is too much then the new recommended ninja.bat is to copy autoninja.bat and modify as needed, perhaps like this: @echo off call python c:\goma\goma-win64\goma_ctl.py ensure_start >nul FOR /f "usebackq tokens=*" %%a in (`python c:\src\depot_tools\autoninja.py "%*"`) do echo %%a & %%a BUG: 758725 Change-Id: Ieee9cf343ee5f22e9988a1969cb7a7a90687666b Reviewed-on: https://chromium-review.googlesource.com/656478Reviewed-by: -
Aaron Gable authored
R=tandrii@chromium.org Bug: 770019 Change-Id: I55d74d67281bd3f79cfd5ba9f57eea082359573e Reviewed-on: https://chromium-review.googlesource.com/693034 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Dan Jacques authored
Add a "ensure_bootstrap" script, which syncs the bootstrapped state of "depot_tools" so that remaining operations become read-only. BUG=chromium:769369 TEST=local Change-Id: I2dab36112b378a926d8201d2ab31a7daa9f5da29 Reviewed-on: https://chromium-review.googlesource.com/691318 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Don Garrett <dgarrett@chromium.org> Reviewed-by:
-
- 28 Sep, 2017 2 commits
-
-
Aaron Gable authored
This is a step away from patch_project, which was a holdover from Rietveld. Instead of mapping "projects" (which are poorly-defined and not guaranteed to be unique) to subpaths, instead map repository urls (which are at least unique). Eventually we may be able to compute this directly from DEPS instead of hardcoding the mapping here, but at least this is a step in the right direction. Bug: 765633 Change-Id: Idd65984fc6edefcbedb0438d38c2338b10b7e8e5 Reviewed-on: https://chromium-review.googlesource.com/690776 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Michael Moss authored
R=agable@chromium.org, phajdan.jr@chromium.org Change-Id: Id883945d61aabf90e11368fbf603196e62ff0f52 Reviewed-on: https://chromium-review.googlesource.com/688675Reviewed-by:
-
