Commits · 124365b8ea553111c78af62c0d7455423a2238e5 · Linshizhi / Chromium_Depot_tools

21 Jun, 2018 5 commits

bot_update: default to non-shallow checkouts. · 124365b8

Andrii Shyshkalov authored Jun 21, 2018

shallow mode is a special git mode that only checks out a shallow copy
of git so the full history is not downloaded. It is not well supported
by googlesource.com servers because git has to do a giant negotiation
with the server and transmit every single commit that the local checkout
has or doesn't have (instead of just the latest commit of each ref),
which ends up taking more than 10x longer than a non-shallow checkout.

R=ehmaldonado, hinoka, iannucci

Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Bug: 855137
Change-Id: I5f9e31f8b2730cf80b79bfd0e08201c33eb942f5
Reviewed-on: https://chromium-review.googlesource.com/1110450
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

124365b8

Fix minor regression in git_upstream_diff. · eb5f85b1

Robert Iannucci authored Jun 21, 2018

89734301 introduced a new useful feature
to `git upstream-diff`, but unfortunately also regressed the behavior
of the tool when used with additional arguments for `git diff`.

This adds some additional documentation to demonstrate the intended
original feature (and fixes some of the bit-rot in the documentation
pipeline).

R=agable@chromium.org, mattm@chromium.org

Change-Id: I3ae48db3232c1ac84a7edbfe2225a17cda391a1e
Reviewed-on: https://chromium-review.googlesource.com/1107491
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

eb5f85b1

gclient: Use posixpath-style separators for cipd subdirs on all platforms. · 4099daa9

John Budorick authored Jun 21, 2018

Bug: 854219
Change-Id: Ibd83135dcb96979f8ab989a248e3e2cf59b9dd43
Reviewed-on: https://chromium-review.googlesource.com/1106698
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

4099daa9

chromite_wrapper: add python3 support for except · 04925ac3

Simon Glass authored Jun 21, 2018

I don't have an account on the chrome gerrit or whatever, and don't
really want to create one for a oneline patch, so I was hoping you'd be
ok with passing this along through the proper channels.

R=ehmaldonado@chromium.org
Signed-off-by: Marty E. Plummer <hanetzer@startmail.com>
Signed-off-by: Simon Glass <sjg@chromium.org>
Bug: None
Change-Id: I3daf58ee802e7c9b144227999f1832b364c5759a
Reviewed-on: https://chromium-review.googlesource.com/1096128Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

04925ac3

Roll recipe dependencies (trivial). · a28b14f1

recipe-roller authored Jun 21, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0e71eb80de4e88898496b6dcc752ca9554c0433c Remove all bootstrapping logic from recipe engine. (iannucci@chromium.org)
  https://crrev.com/59ce6b333bae640882c70e5eb79a3f37662925f4 Do not rely on recipes.py to update recipe_engine. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6c683261f5fd7909be761557e6ec41c697868945
Reviewed-on: https://chromium-review.googlesource.com/1109392Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

a28b14f1

20 Jun, 2018 3 commits

Add yapf · 081487b9

Nodir Turakulov authored Jun 20, 2018

Add yapf and yapf.bat with a vpython spec, so it can be used anywhere, e.g.
bots.

Change-Id: I363c0251ed766b2bb15a8c0f03615bc9a3ecb37a
Reviewed-on: https://chromium-review.googlesource.com/1107170
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

081487b9

Roll recipe dependencies (trivial). · b65b611d

recipe-roller authored Jun 20, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a1a47c8bf997d1f069a3ee088ffa7303a1f8a7cb autoroller: Take into account files with the recipes git attribute. (ehmaldonado@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I373065df9648da4ca1e801c72f672e2ab82b3012
Reviewed-on: https://chromium-review.googlesource.com/1108091
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

b65b611d

pylint: update to 1.4.5 · 49083eaa

Mike Frysinger authored Jun 20, 2018

Grab a few random fixes like deleting old abstract-class-little-used,
abstract-class-not-used, and star-args.

Bug: None
Test: `./pylint *.py` shows no regressions
Change-Id: I494379e18da002d479cb193412fcc49f8c66f376
Reviewed-on: https://chromium-review.googlesource.com/1103763Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

49083eaa

19 Jun, 2018 2 commits

Roll recipe dependencies (trivial). · 1cabdc46

recipe-roller authored Jun 19, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/632ab33e87ee81e14a936c475b4bdbae264154ac Fix all tests to use vpython. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I67c7cae74db2bf38fb3407c34b205b1bdb4df53c
Reviewed-on: https://chromium-review.googlesource.com/1106912Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

1cabdc46

AIX: Enable usage of fetch and gclient · 179059f6

Vasili Skurydzin authored Jun 19, 2018

Change-Id: I4fe559cb44ccd9c6b037b7b096b088adf652ef9b
Reviewed-on: https://chromium-review.googlesource.com/1102718
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

179059f6

15 Jun, 2018 4 commits

Third whitespace change to test builder. · 79d42dfb

Robert Iannucci authored Jun 15, 2018

TBR=nodir@chromium.org, tandrii@chromium.org

Bug: 790434
Change-Id: I6185d79594f63a4652d458d33f9fed325b8d3b85
Reviewed-on: https://chromium-review.googlesource.com/1103302
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

79d42dfb

More testing whitespace. · 09160517

Robert Iannucci authored Jun 15, 2018

TBR=nodir@chromium.org, tandrii@chromium.org

Bug: 790434
Change-Id: I2aa5f1aabeeaa46a64defa4947a5a814851a056c
Reviewed-on: https://chromium-review.googlesource.com/1103010Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

09160517

Whitespace change to test new builder. · 44fccfae

Robert Iannucci authored Jun 15, 2018

R=nodir@chromium.org, tandrii@chromium.org

Bug: 790434
Change-Id: Ibba096deee850fc695a0823e5a22247f394053fb
Reviewed-on: https://chromium-review.googlesource.com/1103007Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

44fccfae

Revert "gclient: Don't allow None URLs (except in .gclient files)" · d683d7ce

Michael Moss authored Jun 15, 2018

This reverts commit 0c91147d.

Reason for revert: This is causing 'gclient revinfo' to fail on the release builders, and appears to be somehow related to the "--output-json" flag.

Original change's description:
> gclient: Don't allow None URLs (except in .gclient files)
> 
> This reverts commit crrev.com/4e9b50ab
> and thus relands the following commits:
> 
>   ebdd0db4: "gclient: Remove URLs from hierarchy."
>   54a5c2ba: "gclient: Refactor PrintRevInfo"
>   083eb25f: "gclient: Don't allow URL to be None."
> 
> When a None URL is specified in a .gclient file, and a DEPS file is
> given, the DEPS file is treated as a .gclient file and its dependencies
> are added.
> 
> Bug: 839925
> 
> Change-Id: I1068b66487874bfa0a788bf9da5273714b6ad39e
> Reviewed-on: https://chromium-review.googlesource.com/1083340
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>

TBR=agable@chromium.org,mmoss@chromium.org,ehmaldonado@chromium.org

Change-Id: I46785bd272b16b3672e553b6443cee6d6b370ec1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839925, 853093
Reviewed-on: https://chromium-review.googlesource.com/1101978Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

d683d7ce

14 Jun, 2018 5 commits

Add infradata/config repo to gclient. · fce7bc9e

Andrii Shyshkalov authored Jun 14, 2018

This way it'll be discoverable by run_presubmit recipe.

R=vadimsh

Bug: 613739
Change-Id: I84ec3b84292940e74e4d707e4d257eb560004f56
Reviewed-on: https://chromium-review.googlesource.com/1102010Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

fce7bc9e

Revert "gclient_scm: Use cherry-picking instead of rebasing." · 690d8d43

Andrii Shyshkalov authored Jun 14, 2018

This reverts commit c9121141.

Reason for revert: broke patch application on infra/config https://crbug.com/853032

Original change's description:
> gclient_scm: Use cherry-picking instead of rebasing.
> 
> We have a problem when in this situation, we checkout |patch| and rebase it on
> top of |base|, thus including an |extra commit| that we shouldn't.
> 
> o master
> |
> . o patch
> |/
> o extra commit
> |
> o base (what gclient synced src at)
> 
> This does merge-base between |patch| and |master|, and cherry-picks only the
> changes belonging to the patch.
> 
> Bug: 850812
> Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e
> Reviewed-on: https://chromium-review.googlesource.com/1098228
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=agable@chromium.org,ehmaldonado@chromium.org

Change-Id: Ib3feeee2f44f5441713383f1dbf08db16fae4717
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850812, 853032
Reviewed-on: https://chromium-review.googlesource.com/1101977Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

690d8d43

gclient_scm: Use cherry-picking instead of rebasing. · c9121141

Edward Lemur authored Jun 14, 2018

We have a problem when in this situation, we checkout |patch| and rebase it on
top of |base|, thus including an |extra commit| that we shouldn't.

o master
|
. o patch
|/
o extra commit
|
o base (what gclient synced src at)

This does merge-base between |patch| and |master|, and cherry-picks only the
changes belonging to the patch.

Bug: 850812
Change-Id: Id09ae1682e53b69ed49b2fb649310de6a6a8a29e
Reviewed-on: https://chromium-review.googlesource.com/1098228
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

c9121141

gclient: Don't allow None URLs (except in .gclient files) · 0c91147d

Edward Lemur authored Jun 14, 2018

This reverts commit crrev.com/4e9b50ab
and thus relands the following commits:

  ebdd0db4: "gclient: Remove URLs from hierarchy."
  54a5c2ba: "gclient: Refactor PrintRevInfo"
  083eb25f: "gclient: Don't allow URL to be None."

When a None URL is specified in a .gclient file, and a DEPS file is
given, the DEPS file is treated as a .gclient file and its dependencies
are added.

Bug: 839925

Change-Id: I1068b66487874bfa0a788bf9da5273714b6ad39e
Reviewed-on: https://chromium-review.googlesource.com/1083340
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

0c91147d

Allow CheckPatchFormatted to cause a failure · 425d9ce2

Nodir Turakulov authored Jun 14, 2018

Extend CheckPatchFormatted to allow other presubmit result types.

Change-Id: I1c592d73657aa9c8a8fd04dbd66f086ce7bb1274
Reviewed-on: https://chromium-review.googlesource.com/1100127Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

425d9ce2

13 Jun, 2018 3 commits

gclient recipe: use env_suffixes insetad of custom ENV manipulation. · cd8d4a65

Andrii Shyshkalov authored Jun 13, 2018

R=iannucci@chromium.org

Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Change-Id: Ie0b042389b7e2c505cd8dbecc1a30a37244ae238
Reviewed-on: https://chromium-review.googlesource.com/1100110Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

cd8d4a65

Roll recipe dependencies (trivial). · 41ff7a03

recipe-roller authored Jun 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/7b5d8f513ee8ba48625d806c5e23d7a4a4b4f44c Update the recipes user guide. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic5a243651225d6f4ca2bc1fb39addca2f4f29428
Reviewed-on: https://chromium-review.googlesource.com/1099635Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

41ff7a03

Roll recipe dependencies (trivial). · 31d53948

recipe-roller authored Jun 13, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c6807980ba3b1770d3c5ad595f21d512e8d6a6de [buildbucket] add test_api to simulate LUCI ci and try builds. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia5d1f8eb85b465bac11461fedb81f2f78e7d33c3
Reviewed-on: https://chromium-review.googlesource.com/1099428Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

31d53948

12 Jun, 2018 1 commit

Roll recipe dependencies (trivial). · e09b6845

recipe-roller authored Jun 12, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8565c92fbfcc717ce5d8bab4489a1d202b85fee0 [raw_io] add support to remove read-only files (maruel@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4ad9167725eef3421409382ad8d255198b9d4552
Reviewed-on: https://chromium-review.googlesource.com/1096600Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

e09b6845

11 Jun, 2018 6 commits

gclient: Use only recursedeps to decide whether to process a dependency (Trigger recipe roller) · b63c4663

Edward Lemur authored Jun 11, 2018

Tbr: agable@chromium.org
Bug: 839925
Change-Id: Ie1dab7cfaa831af65fd9f8d2962161a729fb7a36
Reviewed-on: https://chromium-review.googlesource.com/1096121Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b63c4663

gclient: Use only recursedeps to decide whether to process a dependency. · fbb06aaa

Edward Lemur authored Jun 11, 2018

Bug: 839925
Change-Id: If86cfbdbea795b6da53dec1ea6e44c5af8a3b846
Reviewed-on: https://chromium-review.googlesource.com/1086270Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

fbb06aaa

Improve post_build_ninja_summary.py's incremental build handling · 6be8afd5

Bruce Dawson authored Jun 11, 2018

post_build_ninja_summary.py detects a new incremental build by looking
for the end time stamps to go backwards. This means that repeated builds
that have a single long step will not be reliably detected and will, in
some cases, be missed entirely. This hits me sometimes when doing link
testing - delete an output DLL, rebuild, and the old results may be
displayed again.

This change updates the script to check for a different duration for an
existing record as well as an earlier end time should handle almost all
cases.

This also renames the targets local variable to avoid confusion due
to the targets member variable of the Targets class.

Bug: chromium:787983
Change-Id: I60a371df75d6cb7a55bd46b38156cb109feb8f15
Reviewed-on: https://chromium-review.googlesource.com/1061413
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

6be8afd5

Roll recipe dependencies (trivial). · 9f107316

recipe-roller authored Jun 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/11db7d01eaa21d7706966a532ee36bddc9000e9a recipe_engine: Remove Gitiles backend from fetch. (ehmaldonado@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id160150697f6d1be129605c21ce1b22e8408510a
Reviewed-on: https://chromium-review.googlesource.com/1095835Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

9f107316

Add --log-file arg to post_build_ninja_summary.py · a10370c4

Daniel Bratell authored Jun 11, 2018

Sometimes the log files are not named .ninja_log and then it's
good if you can give the script the actual name and path.

Change-Id: I59e9812c81a83ffac3ecdc8b29887e99bf71b60f
Reviewed-on: https://chromium-review.googlesource.com/1012112Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>

a10370c4

Roll recipe dependencies (trivial). · d21878d7

recipe-roller authored Jun 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/40699af88c76d65ef1b3d364de221611603e2dc6 [cipd] Fix the cipd ensure output handling (phosek@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If6a19c0a13fafdc06b572a4dfb7d403a13a1baee
Reviewed-on: https://chromium-review.googlesource.com/1094705
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

d21878d7

09 Jun, 2018 1 commit

Roll recipe dependencies (trivial). · c3e514ed

recipe-roller authored Jun 09, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b5ea6a8309ecc6cde288f1f97667e495e1d3466d [buildbucket] Make gitiles_commit singular (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie72c0068bbf88238b047453a0c63e3edd5584227
Reviewed-on: https://chromium-review.googlesource.com/1094039Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

c3e514ed

08 Jun, 2018 3 commits

Remove dbghelp.dll hack from packaging script · 3fb5aa7b

Bruce Dawson authored Jun 08, 2018

The script that packages the Visual Studio toolchain had special code to
handle grabbing dbghelp.dll from the VS install and copying it to the
Debuggers directories. This was necessary around VS 2017 RTM to handle
/debug:fastlink but it now causes failures due to mismatched DLLs
leading to a missing ordinal. The hack shouldn't be needed anymore
because we no longer depend on /debug:fastlink (lld!) and because the
Debuggers package is assumed to have been updated to handle VS 2017 by
now.

Bug: 846313
Change-Id: I2b5fd87aaa785ce24a0905d70e7e586ff4838b1c
Reviewed-on: https://chromium-review.googlesource.com/1086990Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

3fb5aa7b

Reland "Reland "Expand variables in gclient flattened output."" · e05f18d4

Edward Lemur authored Jun 08, 2018

This is a reland of ff622244
should_process was set to None in the previous attempt, so CIPD dependencies were not processed.
This CL fixed that.

Original change's description:
> Reland "Expand variables in gclient flattened output."
>
> This is a reland of a32f98e6
>
> Original change's description:
> > Expand variables in gclient flattened output.
> >
> > Bug: 848990
> > Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> > Reviewed-on: https://chromium-review.googlesource.com/1085996
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
>
> Tbr: agable@chromium.org
> Bug: 848990
> Change-Id: I7843544b79b2ab7e2046c187d13ea3eb65fc1b7d
> Reviewed-on: https://chromium-review.googlesource.com/1085975
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 848990
Change-Id: Ic804be1b84bf8402a741a4189b60372075dfb6f3
Reviewed-on: https://chromium-review.googlesource.com/1087368Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

e05f18d4

Add an `--ignore-current` flag to `git cl owners` to start from scratch. · 8e6f58c7

Sidney San Martín authored Jun 08, 2018

Change-Id: Iee6d7cf87281d4ca0abf71a7109f678d5cbbc9f1
Reviewed-on: https://chromium-review.googlesource.com/1091801Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>

8e6f58c7

07 Jun, 2018 1 commit

gclient: Add a test to make sure we're syncing CIPD dependencies. · efe4f897

Edward Lemur authored Jun 07, 2018

Bug: 849374
Change-Id: I5654ed65843c6dae6b7dbee10a40aa35e16803dc
Reviewed-on: https://chromium-review.googlesource.com/1087390
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

efe4f897

06 Jun, 2018 1 commit

Roll mac_toolchain to 796d2b92c · e89dcf7d

Sergey Berezin authored Jun 06, 2018

Relevant changes:
  796d2b92c [mac_toolchain] Always run xcodebuild commands in the correct Xcode context
  42953a5b3 [mac_toolchain] Bug fixes for Xcode 10 and DevToolsSecurity

TBR=maruel@chromium.org

Bug: 849728, 846485
Change-Id: Ifbe6af428d609f4530ba6dcb19c16ebab9432af5
Reviewed-on: https://chromium-review.googlesource.com/1088231Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>

e89dcf7d

05 Jun, 2018 4 commits

Revert "Reland "Expand variables in gclient flattened output."" · b9907703

John Budorick authored Jun 05, 2018

This reverts commit ff622244.

Reason for revert: spec revert for crbug.com/849374

Original change's description:
> Reland "Expand variables in gclient flattened output."
> 
> This is a reland of a32f98e6
> 
> Original change's description:
> > Expand variables in gclient flattened output.
> >
> > Bug: 848990
> > Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> > Reviewed-on: https://chromium-review.googlesource.com/1085996
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> 
> Tbr: agable@chromium.org
> Bug: 848990
> Change-Id: I7843544b79b2ab7e2046c187d13ea3eb65fc1b7d
> Reviewed-on: https://chromium-review.googlesource.com/1085975
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,mmoss@chromium.org,ehmaldonado@chromium.org

Change-Id: I89ffb80893be72f60043e8a6e02f6c0fb6fe5cc1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 848990
Reviewed-on: https://chromium-review.googlesource.com/1086747Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

b9907703

Reland "Expand variables in gclient flattened output." · ff622244

Edward Lemur authored Jun 05, 2018

This is a reland of a32f98e6

Original change's description:
> Expand variables in gclient flattened output.
>
> Bug: 848990
> Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> Reviewed-on: https://chromium-review.googlesource.com/1085996
> Reviewed-by: Michael Moss <mmoss@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Tbr: agable@chromium.org
Bug: 848990
Change-Id: I7843544b79b2ab7e2046c187d13ea3eb65fc1b7d
Reviewed-on: https://chromium-review.googlesource.com/1085975Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

ff622244

Revert "Expand variables in gclient flattened output." · 01cb5105

Edward Lesmes authored Jun 05, 2018

This reverts commit a32f98e6.

Reason for revert:
Doesn't work when there are variables which definition includes other variables, e.g.:

'cros_download_vm': '"{cros_board}" == "amd64_generic"',

Original change's description:
> Expand variables in gclient flattened output.
> 
> Bug: 848990
> Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
> Reviewed-on: https://chromium-review.googlesource.com/1085996
> Reviewed-by: Michael Moss <mmoss@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,mmoss@chromium.org,ehmaldonado@chromium.org

Change-Id: I7e81000e92aa352e45b420845bb1dcc8572f1962
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 848990
Reviewed-on: https://chromium-review.googlesource.com/1085974Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

01cb5105

Expand variables in gclient flattened output. · a32f98e6

Edward Lemur authored Jun 04, 2018

Bug: 848990
Change-Id: I0ad7e4f965973edbc5a335bd30f9cbd7b04abff2
Reviewed-on: https://chromium-review.googlesource.com/1085996Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

a32f98e6

04 Jun, 2018 1 commit

[git-cl-try] Handle absence of builds · 23d75d2d

Nodir Turakulov authored Jun 04, 2018

If there are no builds in build search response, the response is {}.
Handle this case.

R=qyearsley

Bug: 849361
Change-Id: I9f0472e140698a1d1c5b98b301bc562ac457785b
Reviewed-on: https://chromium-review.googlesource.com/1085899Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>

23d75d2d