1. 01 Jun, 2017 3 commits
    • Dan Jacques's avatar
      [.bat] Remove "depot_tools" override. (#2) · 74809c1b
      Dan Jacques authored
      Second attempt at landing. Fix quotes around python in "gclient.bat".
      
      Currently, all ".bat" entry points use "~dp0python" to ensure that the
      Python that is used to execute the tool is the one in depot_tools. This
      prevents any sort of system override.
      
      Remove this override so that PATH solely determines which Python is
      used. To accommodate users who invoked these tools without Python on the
      PATH, we still still add "depot_tools" as a catch-all PATH suffix.
      
      Some tools were also not using DOS-style line endings. This CL fixes
      this.
      
      BUG=chromium:714293, chromium:724902
      TEST=None
      
      Change-Id: I0fceb99c8adb96e72dac706819be032d400aad37
      Reviewed-on: https://chromium-review.googlesource.com/521704
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarMarc-Antoine Ruel <maruel@chromium.org>
      Reviewed-by: 's avatarScott Graham <scottmg@chromium.org>
      Reviewed-by: 's avatarNodir Turakulov <nodir@chromium.org>
      74809c1b
    • Daniel Jacques's avatar
      Revert "[.bat] Remove "depot_tools" override." · 96fa295a
      Daniel Jacques authored
      This reverts commit 2f5f0b7a.
      
      Reason for revert: <INSERT REASONING HERE>
      
      Original change's description:
      > [.bat] Remove "depot_tools" override.
      > 
      > Currently, all ".bat" entry points use "~dp0python" to ensure that the
      > Python that is used to execute the tool is the one in depot_tools. This
      > prevents any sort of system override.
      > 
      > Remove this override so that PATH solely determines which Python is
      > used. To accommodate users who invoked these tools without Python on the
      > PATH, we still still add "depot_tools" as a catch-all PATH suffix.
      > 
      > Some tools were also not using DOS-style line endings. This CL fixes
      > this.
      > 
      > BUG=chromium:714293, chromium:724902
      > TEST=None
      > 
      > Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5
      > Reviewed-on: https://chromium-review.googlesource.com/517236
      > Commit-Queue: Daniel Jacques <dnj@chromium.org>
      > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
      > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
      > 
      
      TBR=maruel@chromium.org,iannucci@chromium.org,vadimsh@chromium.org,dnj@chromium.org
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      BUG=chromium:714293, chromium:724902
      
      Change-Id: I822abdd4e02abd32d2f4789fb16d5a7f78fdd02d
      Reviewed-on: https://chromium-review.googlesource.com/521867Reviewed-by: 's avatarDaniel Jacques <dnj@chromium.org>
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      96fa295a
    • Dan Jacques's avatar
      [.bat] Remove "depot_tools" override. · 2f5f0b7a
      Dan Jacques authored
      Currently, all ".bat" entry points use "~dp0python" to ensure that the
      Python that is used to execute the tool is the one in depot_tools. This
      prevents any sort of system override.
      
      Remove this override so that PATH solely determines which Python is
      used. To accommodate users who invoked these tools without Python on the
      PATH, we still still add "depot_tools" as a catch-all PATH suffix.
      
      Some tools were also not using DOS-style line endings. This CL fixes
      this.
      
      BUG=chromium:714293, chromium:724902
      TEST=None
      
      Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5
      Reviewed-on: https://chromium-review.googlesource.com/517236
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Reviewed-by: 's avatarMarc-Antoine Ruel <maruel@chromium.org>
      2f5f0b7a
  2. 24 May, 2017 1 commit
    • Dan Jacques's avatar
      Remove special Cygwin PATH manipulation from .bat. · 1b9a43aa
      Dan Jacques authored
      Several boilerplate batch files include a provision to prepend
      "depot_tools" to PATH prior to running those tools. This undermines
      the utility of PATH overrides, since these tools specifically force their
      "depot_tools" sub-paths to be used regardless of environment.
      
      The origin of this behavior is likely limited to a specific fix for a
      specific problem, but was then perpetuated by the copy/paste of
      boilerplate bootstrap code as more bootstraps were added.
      
      This is important in upcoming configurations, where core tools such as
      Python and Git will be overridden via PATH on the bots.
      
      Cygwin users who depended on this behavior should just add "depot_tools"
      to their PATH in the appropriate location (i.e. in their .bashrc).
      
      BUG=chromium:714293, chromium:724902
      TEST=None
      
      Change-Id: Ie948a430847d20326d2411e9296cacd02f83a537
      Reviewed-on: https://chromium-review.googlesource.com/510290
      Commit-Queue: Daniel Jacques <dnj@chromium.org>
      Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      1b9a43aa
  3. 09 Jun, 2014 1 commit
  4. 26 Feb, 2014 1 commit
  5. 21 Sep, 2012 2 commits
  6. 04 May, 2012 1 commit
  7. 13 Apr, 2012 1 commit
  8. 27 Sep, 2011 1 commit
  9. 24 Nov, 2009 1 commit
  10. 11 May, 2009 1 commit
  11. 07 May, 2009 1 commit
  12. 24 Apr, 2009 1 commit
  13. 23 Apr, 2009 1 commit