Commit 1b9a43aa authored by Dan Jacques's avatar Dan Jacques Committed by Commit Bot

Remove special Cygwin PATH manipulation from .bat.

Several boilerplate batch files include a provision to prepend
"depot_tools" to PATH prior to running those tools. This undermines
the utility of PATH overrides, since these tools specifically force their
"depot_tools" sub-paths to be used regardless of environment.

The origin of this behavior is likely limited to a specific fix for a
specific problem, but was then perpetuated by the copy/paste of
boilerplate bootstrap code as more bootstraps were added.

This is important in upcoming configurations, where core tools such as
Python and Git will be overridden via PATH on the bots.

Cygwin users who depended on this behavior should just add "depot_tools"
to their PATH in the appropriate location (i.e. in their .bashrc).

BUG=chromium:714293, chromium:724902
TEST=None

Change-Id: Ie948a430847d20326d2411e9296cacd02f83a537
Reviewed-on: https://chromium-review.googlesource.com/510290
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
parent 56664461
......@@ -4,8 +4,5 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\apply_issue.py" %*
......@@ -4,8 +4,5 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\cit.py" %*
......@@ -4,8 +4,5 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\clang_format.py" %*
......@@ -4,8 +4,5 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\clang_format_merge_driver.py" %*
......@@ -4,8 +4,5 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\commit_queue.py" %*
@echo off
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
call python "%~dp0cpplint.py" %*
......@@ -4,8 +4,5 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\depot-tools-auth.py" %*
......@@ -3,8 +3,5 @@
:: Use of this source code is governed by a BSD-style license that can be
:: found in the LICENSE file.
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\download_from_google_storage.py" %*
......@@ -4,9 +4,6 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Synchronize the root directory before deferring control back to gclient.py.
call "%~dp0\update_depot_tools.bat"
......
......@@ -4,9 +4,6 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Synchronize the root directory before deferring control back to gclient.py.
call "%~dp0update_depot_tools.bat" %*
......
......@@ -4,8 +4,5 @@
:: found in the LICENSE file.
setlocal
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\gn.py" %*
......@@ -3,8 +3,5 @@
:: Use of this source code is governed by a BSD-style license that can be
:: found in the LICENSE file.
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\roll_dep_svn.py" %*
......@@ -3,8 +3,5 @@
:: Use of this source code is governed by a BSD-style license that can be
:: found in the LICENSE file.
:: This is required with cygwin only.
PATH=%~dp0;%PATH%
:: Defer control.
%~dp0python "%~dp0\roll_dep.py" %*
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment