- 21 Sep, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ad0e2563a79f19f916cf2939811a2019dec16386 Improve local execution of recipes (martiniss@google.com) https://crrev.com/d5fd7cc14d7f0a82d1358617f1ec94c4417ec85e [buildbucket] Split try_build/ci_build (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I47055f996a36b2b9b39de7142d062b9c59be429d Reviewed-on: https://chromium-review.googlesource.com/1239095 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
Recipe Roller <recipe-roller@chromium.org>
-
Nodir Turakulov authored
This reverts commit 7e301cff. Reason for revert: internal builds failed, e.g. bugdroid Original change's description: > [gclient] Use canonical URLs in solutions > > Strip ".git" suffix from all solution URLs. > > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: release_scripts > Bug: 877161 > Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d > Reviewed-on: https://chromium-review.googlesource.com/1237332 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Nodir Turakulov <nodir@chromium.org> TBR=nodir@chromium.org,tandrii@chromium.org,martiniss@chromium.org,jbudorick@chromium.org Change-Id: Ie24e10844ceb89071c9e665f2aa7dde9f9bf6e6c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877161 Reviewed-on: https://chromium-review.googlesource.com/1237423Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
- 20 Sep, 2018 7 commits
-
-
Nodir Turakulov authored
Strip ".git" suffix from all solution URLs. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Bug: 877161 Change-Id: I0cb9cc512fdd9cc5e53ade6bc1d725dc84f7563d Reviewed-on: https://chromium-review.googlesource.com/1237332Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/66dfa7cca67be5376d6cb54b462e9ccd832e4f01 [buildbucket] Add gitiles_commit shortcut (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icc8a9462ec44431c60f71a22f6ecc4d82aaa1e26 Reviewed-on: https://chromium-review.googlesource.com/1236897Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/39df254c20b7052fed669e3319036b20f96e75e3 [buildbucket] Fix typo. (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I566c81d35832b76a43e9bd54838bb6f95a0d8bad Reviewed-on: https://chromium-review.googlesource.com/1236896Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/673743d3e861ad9c6d9a8cc71088f4be7d01a1bb [buildbucket] add builder_name (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8aa6eb66e991d5ec5ec556a3fa3b6ea43648fc40 Reviewed-on: https://chromium-review.googlesource.com/1236895Reviewed-by:
-
Dirk Pranke authored
Hopefully this will also actually speed up downloads like it claims it will :). Bug: 875100 Change-Id: I712df6272135b1fa3b1f32095916b18128644718 Reviewed-on: https://chromium-review.googlesource.com/1179078Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Sidney San Martín authored
These can just be from not having a network connection. Bug: 887540 Change-Id: Ie025cc278a4633d688bfb34544ecaaacb2df1bad Reviewed-on: https://chromium-review.googlesource.com/1236893 Auto-Submit: Sidney San Martín <sdy@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4232dd9f1c5aa35874d70634ae86f1cc4720bc6a Add documentation for placeholders. (erikchen@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie2747491eef99bf0227d484be71a54203b02c794 Reviewed-on: https://chromium-review.googlesource.com/1236894Reviewed-by:
-
- 19 Sep, 2018 8 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ec1f045f324fd25c985a60cdcddb913f82da0490 Add AnnotationContains post processing step (erikchen@chromium.org) https://crrev.com/702c6847b3cc129007d58f1ba864b009e820c11e [buildbucket] Populate created_by from legacy property (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb26c38e87c3789fce58fba5c8a5d0553be6bba3 Reviewed-on: https://chromium-review.googlesource.com/1234978Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ecba3385f199e9f9aecf783d7ce8d87c23775640 [buildbucket] Add bucket_v1 property (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8ed25d6f14e9526c4157a23c9a656c2be612a063 Reviewed-on: https://chromium-review.googlesource.com/1234977 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
It was superseded by repo_path_map. Bug: 694348 Change-Id: If6b4790290bf2573f2a9367334decf064d382f52 Reviewed-on: https://chromium-review.googlesource.com/1232875 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
John Budorick authored
Bug: 884434 Change-Id: Id156709e14d1c3506a1236bc1e59f8468381a402 Reviewed-on: https://chromium-review.googlesource.com/1232257 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Edward Lemur authored
This is a reland of 67ef3f67 We no longer call cipd unconditionally. Original change's description: > gclient: delete unversioned directory before adding cipd dep for the same path > > Bug: 882611 > Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050 > Reviewed-on: https://chromium-review.googlesource.com/1228655 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Bug: 882611 Change-Id: I683bfc62bd1eebfec0853583f96f3981c2c6bdf2 Reviewed-on: https://chromium-review.googlesource.com/1232891Reviewed-by:
-
Michael Achenbach authored
TBR=smut@chromium.org,nodir@chromium.org Bug: 711249 Change-Id: I031497eeeec02f16c182fbe2e46c6a02f0745df9 Reviewed-on: https://chromium-review.googlesource.com/1232896Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/7a22cddcd7f3255e357a63c73df4396a43def8cd [context] Stringify name_prefix if unicode in api.context (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib38a903cbb92fae8dd5c554f1054b44ef93110d0 Reviewed-on: https://chromium-review.googlesource.com/1232589Reviewed-by:
-
Robert Iannucci authored
It looks like PNaCl actually depends on MSVC's presance, but doesn't actually run any compile steps with it (instead using clang). That means that mspdbsrv never actually runs during their build, and then the taskkill fails. R=hinoka@chromium.org, tandrii@chromium.org Bug: 861512 Change-Id: I004d28f198224adaf16b1d3f14401b0d2a7d700b Reviewed-on: https://chromium-review.googlesource.com/1232885Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 18 Sep, 2018 18 commits
-
-
Nodir Turakulov authored
Not used R=tandrii@chromium.org Bug: 694348 Change-Id: I3188881b1f92df1cbfdbf3aafe309abb9488d9b2 Reviewed-on: https://chromium-review.googlesource.com/1232874 Auto-Submit: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
Remove PATCH_PROJECT from gclient config. It is not used. R=tandrii@chromium.org Bug: 694348 Change-Id: I56e4aefbe5e9b23296553bb61f878d6426197fa7 Reviewed-on: https://chromium-review.googlesource.com/1232873 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
It is not used. get_gerrit_patch_root is used instead. Bug: 694348 Change-Id: Icc717e38cbcaa8050c8ce8a364202b81d7f9cf2c Reviewed-on: https://chromium-review.googlesource.com/1231282 Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
This reverts commit 67ef3f67. Reason for revert: might have broken GCE/ccompute fleet. Original change's description: > gclient: delete unversioned directory before adding cipd dep for the same path > > Bug: 882611 > Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050 > Reviewed-on: https://chromium-review.googlesource.com/1228655 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> TBR=tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: Ia2172b1b0d236357edf93dacf57f3bf7d80d5968 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882611 Reviewed-on: https://chromium-review.googlesource.com/1231699Reviewed-by:
-
Nodir Turakulov authored
Use get_gerrit_patch_root in bot_update.ensure_checkout. This fixes some tests expectations that expected CI builds to pass --patch_root flag. Also unify "root" and "patch_root" variables in ensure_checkout. Simpler. This CL requires nontrivial rolls in all downstream packages because all packages have incorrect expectations and/or tests. In particular, this removes --patch_root flag from non-tryjob test cases. Some tests are supposed to test tryjob scenario, but they use properties.generic instead of properties.tryserver (or buildbucket.try_build) Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: release_scripts Recipe-Nontrivial-Roll: skiabuildbot Bug: 694348 Change-Id: Ibc594fa42e3b4d2823672b41dda2d97154b10d38 Reviewed-on: https://chromium-review.googlesource.com/1231280 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
R=ajp@chromium.org Bug: 881860 Change-Id: I2608132730cf907ea5bb86476490eafc37e24275 Reviewed-on: https://chromium-review.googlesource.com/1227438 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
Update set_patch_project_revision to use repo_path_map instead of patch_projects. Also rename to set_patch_repo_revision. Bug: 694348 Change-Id: Iba31f4910f8282160000b8fcef197052597530a4 Reviewed-on: https://chromium-review.googlesource.com/1226107 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 882611 Change-Id: I46e41cc9693b90874b5d6569a12ec638eaac1050 Reviewed-on: https://chromium-review.googlesource.com/1228655 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
Update bot_update full.py example to use buildbucket module. Also remove buidlbucket example. Bug: 694348 Change-Id: Ib784583e0ded5ac95fabe99bc39a53f4646e80fc Reviewed-on: https://chromium-review.googlesource.com/1231281Reviewed-by:
-
Sergiy Byelozyorov authored
R=ehmaldonado@chromium.org, machenbach@chromium.org Bug: 878303 Change-Id: Ia90001025babe692e481eb74fdbb4a66ce9a22f8 Reviewed-on: https://chromium-review.googlesource.com/1230074 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Nodir Turakulov authored
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1217670/17 used solution instead of solution name. TBR=tandrii@chromium.org Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Bug: 694348 Change-Id: I829cba9223d73383791b018f9a23598443e8fa2c Reviewed-on: https://chromium-review.googlesource.com/1231278Reviewed-by:
-
Nodir Turakulov authored
Add a shortcut for getting local path to the patch repo. In bot_update.api._destination_branch, start using it instead of reading gclient config directly. This removes one more patch_project usage. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Bug: 694348 Change-Id: If05371d0f6d11be6803ffa8392e029f5860dda25 Reviewed-on: https://chromium-review.googlesource.com/1217670 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
Together with already committed cipd_client_version.digests file, this cryptographically binds contents of CIPD packages used by depot_tools with depot_tool's git revision (assuming the CIPD client pinned by cipd_client_version.digests is trusted too, which can presumably be verified when it is being pinned). This holds true even if the CIPD backend is compromised. The worst that can happen is a denial of service (e.g. if the backend refuses to serve packages at all). If a bad backend tries to serve a malicious (unexpected) CIPD client, 'cipd' bootstrap script (and its powershell counterpart) will detect a mismatch between SHA256 of the fetched binary and what's specified in cipd_client_version.digests, and will refuse to run the untrusted binary. Similarly, if the bad backend tries to serve some other unexpected package (in place of a package specified in cipd_manifest.txt), the CIPD client (already verified and trusted as this point) will detect a mismatch between what was fetched and what's pinned in cipd_manifest.versions, and will refuse to install untrusted files. cipd_manifest.versions was generated from cipd_manifest.txt by: $ cipd ensure-file-resolve -ensure-file cipd_manifest.txt This will have to be rerun each time cipd_manifest.txt is updated. There's a presubmit check that verifies *.versions file is up-to-date (it's part of 'cipd ensure-file-verify'). BUG=870166 R=nodir@chromium.org, iannucci@chromium.org, tandrii@chromium.org Change-Id: I25314adf0a9b05c69cd16e75aff01dbc79c87aa5 Reviewed-on: https://chromium-review.googlesource.com/1227435 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
-
Eric Boren authored
This reverts commit 18b4479c. Reason for revert: Breaking WebRTC roller: https://luci-milo.appspot.com/buildbot/client.webrtc.fyi/Auto-roll%20-%20WebRTC%20DEPS/12788 Original change's description: > gerrit_util: Support OAuth2 bearer tokens in CookieAuthenticator > > Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91 > Reviewed-on: https://chromium-review.googlesource.com/1221826 > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> TBR=vadimsh@chromium.org,dnj@chromium.org,borenet@chromium.org,tandrii@chromium.org Change-Id: I93bbd2d09cd2b27d9a7aa98fc15d60c5033a38cd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1231433Reviewed-by:
Eric Boren <borenet@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f7a834467c55fc302e5da1bdc0ef78c7bdecf2d9 Add comment to failing_step to indicate that it raises an exception. (erikchen@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9b3ab8e2145e52711a7a725d6af77afb93f8ad0b Reviewed-on: https://chromium-review.googlesource.com/1230793 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by:
-
Michael Achenbach authored
V8 uses buildbucket.py to trigger flake-bisect jobs on command line. It's more convenient if the build url is shown. Bug: 711249 Change-Id: I5737c6f3fd72b60517662e8a4808186d6acc71db Reviewed-on: https://chromium-review.googlesource.com/1226912 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
smut <smut@google.com>
-
Eric Boren authored
Change-Id: I9fd3e2fa9ea16d7f057290e77a81f7009c7c9d91 Reviewed-on: https://chromium-review.googlesource.com/1221826Reviewed-by:
-
Vadim Shtayura authored
The new version uses SHA256 for uploads by default. It also fully supports $ResolvedVersions and 'selfupdate-roll'. The roll was generated by: $ ./cipd selfupdate-roll \ -version-file cipd_client_version \ -version git_revision:fb963f0f43e265a65fb7f1f202e17ea23e947063 BUG=821194, 870166 R=nodir@chromium.org, iannucci@chromium.org Change-Id: If7c23c43ff2c1bf50c9c50f4e9e17a23e84859b9 Reviewed-on: https://chromium-review.googlesource.com/1227431 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
-
- 17 Sep, 2018 3 commits
-
-
Andrii Shyshkalov authored
R=ajp@chromium.org Bug: 881860 Change-Id: I2a5fc981fce05664ea077cad74458bc38c37f1e7 Reviewed-on: https://chromium-review.googlesource.com/1227439 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Print "git cl comments" json to stdout when the output file is "-" Change-Id: I91021317e52019a0d499cccc4f40f062127b300e Reviewed-on: https://chromium-review.googlesource.com/1228094 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Andrii Shyshkalov authored
Test: verified the same reviews list is produced w/o and w/ this change. Change-Id: I72be85734a84d96a06b74515e64344fc203b1eed Reviewed-on: https://chromium-review.googlesource.com/1227442Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 14 Sep, 2018 2 commits
-
-
Vadim Shtayura authored
Not enabling it yet, since PRESUBMIT.py uses presubmit_canned_checks.py from depot_tools at HEAD, not from a CL (thus enabling this check in this CL will make it fail the presubmit). R=nodir@chromium.org BUG=870166 Change-Id: I97802ec37f1f7513dfca3950f7f38a5c51ab0350 Reviewed-on: https://chromium-review.googlesource.com/1227432Reviewed-by:
-
Vadim Shtayura authored
Errors during the download should be reported as such, not as "failed to grab the lock file". R=nodir@chromium.org, iannucci@chromium.org BUG=853722 Change-Id: If24f4587693852eed0608450bcd311cf3bafd2c3 Reviewed-on: https://chromium-review.googlesource.com/1226106Reviewed-by:
-
