- 02 Nov, 2017 1 commit
-
-
Aaron Gable authored
Bug: 770327 Change-Id: I9dd0ed0be0761de4968136f563e8986b979c35cf Reviewed-on: https://chromium-review.googlesource.com/723824 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by: Ravi Mistry <rmistry@chromium.org>
-
- 20 Apr, 2017 1 commit
-
-
Andrii Shyshkalov authored
R=maruel@chromium.org,jrobbins@chromium.org BUG=712060 Change-Id: I16651d9926fe0f3a74549a4c03896220f9a58f94 Reviewed-on: https://chromium-review.googlesource.com/482659Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 15 Feb, 2017 1 commit
-
-
Kenneth Russell authored
This makes them accessible to presubmit scripts' PostUploadHook. Fixed bugs where caching needed to be bypassed in order for sequential PostUploadHooks to see each others' results. BUG=688765 Change-Id: I56c0c6b6419e2474f4b7f701be036fb2a524f8e3 Reviewed-on: https://chromium-review.googlesource.com/439877Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
-
- 16 Dec, 2016 1 commit
-
-
Quinten Yearsley authored
This affects a bunch of files, but only changes comments, and shouldn't make any difference to behavior. The purpose is to slightly improve readability of pylint disable comments. Change-Id: Ic6cd0f8de792b31d91c6125f6da2616450b30f11 Reviewed-on: https://chromium-review.googlesource.com/420412Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
-
- 29 Nov, 2016 1 commit
-
-
Andrii Shyshkalov authored
R=katthomas@chromium.org,sergiyb@chromium.org BUG=chromium:601260 Change-Id: I79e1e807d1f8aed8d294742974d1f42a852c6b13 Reviewed-on: https://chromium-review.googlesource.com/415147 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
-
- 06 Jul, 2016 1 commit
-
-
tandrii authored
BUG=622828 R=emso@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2127633003
-
- 11 Apr, 2016 1 commit
-
-
tandrii@chromium.org authored
Namely these errors when applying patch: <urlopen error [Errno 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond> <urlopen error [Errno 104] Connection reset by peer> R=sergiyb@chromium.org,phajdan.jr@chromium.org BUG=601260 Review URL: https://codereview.chromium.org/1876093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299837 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Feb, 2016 1 commit
-
-
dsansome@chromium.org authored
This will hopefully make Rietveld._send retry 500s like it promises to BUG=585632 Review URL: https://codereview.chromium.org/1681333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298726 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Feb, 2016 1 commit
-
-
dsansome@chromium.org authored
BUG=585632 TBR=agable Review URL: https://codereview.chromium.org/1686753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298693 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Feb, 2016 1 commit
-
-
dsansome@chromium.org authored
This will hopefully make Rietveld._send retry 500s like it promises to BUG= Review URL: https://codereview.chromium.org/1683603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298688 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jan, 2016 1 commit
-
-
sebmarchand@chromium.org authored
Currently apply_issue fail if the content of a newly added file is missing (because of the 900ko threshold in upload.py). But this doesn't apply to the large file that get modified (instead of being added). This is wrong because apply_issue will indicates a success without really applying the patch. It looks like the patch content is set to "None" in this cases (the string value, not the empty value None). Review URL: https://codereview.chromium.org/1612323004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298366 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Dec, 2015 1 commit
-
-
tandrii@chromium.org authored
BUG=564304 R=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1497763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297830 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Dec, 2015 1 commit
-
-
tandrii@chromium.org authored
BUG=564304 TBR=sergiyb@chromium.org Review URL: https://codereview.chromium.org/1496643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297793 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Nov, 2015 1 commit
-
-
cbentzel@chromium.org authored
Manually generating param strings shows that the 1/2 values do not work. Review URL: https://codereview.chromium.org/1482153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297732 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Nov, 2015 1 commit
-
-
sergiyb@chromium.org authored
R=tandrii@chromium.org BUG=560785 Review URL: https://codereview.chromium.org/1475063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297701 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Oct, 2015 1 commit
-
-
dsansome@chromium.org authored
To fix this flake: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/1216/steps/bot_update/logs/stdio BUG= Review URL: https://codereview.chromium.org/1417963005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297234 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Oct, 2015 1 commit
-
-
sergiyb@chromium.org authored
This will make explanation provided by Rietveld visible to the user, e.g. "Request to https://codereview.chromium.org/1386443003/edit_flags failed: Cannot set commit on an issue that does not have a commit queue". R=phajdan.jr@chromium.org BUG=529339 Review URL: https://codereview.chromium.org/1387833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297009 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 Oct, 2015 1 commit
-
-
tandrii@chromium.org authored
R=sergeyberezin@chromium.org BUG=537417 Review URL: https://codereview.chromium.org/1388463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296995 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Oct, 2015 1 commit
-
-
stip@chromium.org authored
Revert of Temporary fix for codereview cert issue. (patchset #3 id:2 of https://codereview.chromium.org/1376333002/ ) Reason for revert: Outage is now over Original issue's description: > Temporary fix for codereview cert issue. > > BUG=537763 > R=stip@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959 TBR=tandrii@google.com,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537763 Review URL: https://codereview.chromium.org/1374223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Sep, 2015 1 commit
-
-
tandrii@chromium.org authored
BUG=537763 R=stip@chromium.org Review URL: https://codereview.chromium.org/1376333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296959 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Aug, 2015 1 commit
-
-
rmistry@google.com authored
Context= https://groups.google.com/a/chromium.org/d/msg/infra-dev/GNKEiqLqKPg/M_rjXvwvLQAJ BUG= Review URL: https://codereview.chromium.org/1315893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296430 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Jun, 2015 1 commit
-
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2015 2 commits
-
-
rmistry@google.com authored
Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) Reason for revert: Ran into a crash during the bot_update step here: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 Original issue's description: > Find, upload and apply patchset dependencies. > > Here is an explanation of the changes in each module: > > * git_cl.py - > IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. > > * upload.py - > Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). > > * rietveld.py - > Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). > > * apply_issue.py - > If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). > apply_issue will then loop over the list applying each dependency. > Note: The apply_issue.py diff looks much worse than it is. Please see my comment in > https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 > > > Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: > * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') > * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') > * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') > * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') > Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. > > > Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw > > BUG=502255 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 TBR=agable@chromium.org,jrobbins@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502255 Review URL: https://codereview.chromium.org/1200773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jun, 2015 1 commit
-
-
tandrii@google.com authored
R=pgervais@chromium.org, hinoka@chromium.org BUG=489569 Review URL: https://codereview.chromium.org/1145313002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295723 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
It is done in preparation for switching to OAuth2 as default (and only) authentication method. Having all auth options handled by the same code makes it easier to gradually add OAuth2 support. As part of this, some options that would no longer work with OAuth2 (and that are not being used from anywhere now, as far as I can tell) are removed: * Passing account password for authentication via command line. * Overriding 'Host' header when making requests to Rietveld (won't work with SSL anyway). * --account_type option (seems to be ClientLogin specific). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1075723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2015 1 commit
-
-
vadimsh@chromium.org authored
They were used by CQ code, but CQ forked relevant parts of depot_tools already and no longer uses this code. These properties are unused now (as far as I can tell searching through code). They expose auth implementation details that better to be hidden (since they will change with OAuth2 adoption). R=maruel@chromium.org BUG=356813 Review URL: https://codereview.chromium.org/1063263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294707 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Feb, 2015 2 commits
-
-
phajdan.jr@chromium.org authored
Noticed by Jens Widell in https://codereview.chromium.org/932333003/ TBR=maruel BUG=459855 Review URL: https://codereview.chromium.org/933373004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294123 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
R=machenbach TBR=maruel BUG=459855 Review URL: https://codereview.chromium.org/932333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294121 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Jan, 2015 1 commit
-
-
sheyang@chromium.org authored
BUG=431792 Review URL: https://codereview.chromium.org/805663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293525 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Aug, 2014 1 commit
-
-
hinoka@chromium.org authored
Also added a tiny bit of exponential backoff. BUG=375479 Review URL: https://codereview.chromium.org/350433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291682 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Jun, 2014 1 commit
-
-
sergiyb@chromium.org authored
BUG=373797 R=maruel@chromium.org Review URL: https://codereview.chromium.org/323363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@277040 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Apr, 2014 1 commit
-
-
pgervais@chromium.org authored
Added automatic detection of OAuth2 token expiracy. Token is automatically renewed when necessary. BUG=363825 Review URL: https://codereview.chromium.org/243323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@264871 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Apr, 2014 1 commit
-
-
pgervais@chromium.org authored
Renewal of OAuth2 credentials did not work on appengine because it replies with 302 instead of 401 when authentication fails. Configured it to attempt credentials renewal on a 302. Of course this will prevent any 302 from working normally, but it works with Rietveld since it does not use 302. BUG=319446 Review URL: https://codereview.chromium.org/238273011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@264639 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Apr, 2014 1 commit
-
-
pgervais@chromium.org authored
BUG=319446 Review URL: https://codereview.chromium.org/236093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263750 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2014 1 commit
-
-
agable@chromium.org authored
When rietveld.py overrides upload.py's logging module, it generally works fine... until someone tries to run upload.py with any level of verbosity. Then the calls to logging.getLogger and logging.INFO/logging.DEBUG fail. This patches upload.py to properly use a module-scope logger so that rietveld.py doesn't have to perform invasive surgery, and everything just works. This version of upload.py taken from upstream Rietveld at: changeset: 1267:d7b39eca7dbe branch: chromium R=djacques@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/221423007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262793 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Mar, 2014 1 commit
-
-
sergeyberezin@chromium.org authored
CL that cause the issue: https://codereview.chromium.org/183793010 Symptoms: commit queue presubmit checks failed. BUG=None Review URL: https://codereview.chromium.org/215163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259947 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Mar, 2014 2 commits
-
-
pgervais@chromium.org authored
Added oauth2client and httplib to third_party BUG=348233 Review URL: https://codereview.chromium.org/183793010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259643 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
The commit queue can't successfully run presubmit checks on top of ReadOnlyRietveld because it requires access to the password field to pass through to presubmit_shim. R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/197213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259611 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Mar, 2014 1 commit
-
-
machenbach@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/178223016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254321 0039d316-1c4b-4281-b951-d872f2087c98
-