Commit 473527c7 authored by cbentzel@chromium.org's avatar cbentzel@chromium.org

rietveld.py: Change three_state_keys to emit "True" or "False" query params rather than 1/2.

Manually generating param strings shows that the 1/2 values do not work.

Review URL: https://codereview.chromium.org/1482153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297732 0039d316-1c4b-4281-b951-d872f2087c98
parent ad6451a7
......@@ -313,7 +313,7 @@ class Rietveld(object):
for key in sorted(three_state_keys):
value = three_state_keys[key]
if value is not None:
url += '&%s=%d' % (key, int(value) + 1)
url += '&%s=%s' % (key, value)
if keys_only:
url += '&keys_only=True'
......
......@@ -340,9 +340,9 @@ class RietveldTest(BaseFixture):
'&modified_before=2010-02-01'
'&owner=owner%40example.com'
'&reviewer=reviewer%40example.com'
'&closed=2'
'&commit=2'
'&private=2'
'&closed=True'
'&commit=True'
'&private=True'
'&keys_only=True'
'&with_messages=True'
'&limit=23')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment