• Jakob Gruber's avatar
    Reland "[regexp] Correctly escape a backslash-newline sequence" · eea168f8
    Jakob Gruber authored
    This is a reland of 7d1f95d6
    
    The reland fixes a performance issue in that we incorrectly marked
    every pattern containing a backslash as needing to be escaped,
    resulting in a new string allocation instead of reusing the existing
    string.
    
    Original change's description:
    > [regexp] Correctly escape a backslash-newline sequence
    >
    > When printing the source string, a backslash-newline sequence ('\\\n',
    > '\\\r', '\\\u2028', '\\\u2029') should be formatted as '\n', '\r',
    > '\u2028', '\u2029', respectively. Prior to this CL it was formatted as
    > a backslash followed by the literal newline character.
    >
    > Bug: v8:8615
    > Change-Id: Iac90195c56ea1707ea8469066b0cc967ea87fc73
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016583
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65986}
    
    Bug: v8:8615,chromium:1046678
    Change-Id: I5d75904f1ea543ec679649668e54749821116442
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074159
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66476}
    eea168f8
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...