• Jakob Gruber's avatar
    Reland "[regexp] Correctly escape a backslash-newline sequence" · eea168f8
    Jakob Gruber authored
    This is a reland of 7d1f95d6
    
    The reland fixes a performance issue in that we incorrectly marked
    every pattern containing a backslash as needing to be escaped,
    resulting in a new string allocation instead of reusing the existing
    string.
    
    Original change's description:
    > [regexp] Correctly escape a backslash-newline sequence
    >
    > When printing the source string, a backslash-newline sequence ('\\\n',
    > '\\\r', '\\\u2028', '\\\u2029') should be formatted as '\n', '\r',
    > '\u2028', '\u2029', respectively. Prior to this CL it was formatted as
    > a backslash followed by the literal newline character.
    >
    > Bug: v8:8615
    > Change-Id: Iac90195c56ea1707ea8469066b0cc967ea87fc73
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2016583
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65986}
    
    Bug: v8:8615,chromium:1046678
    Change-Id: I5d75904f1ea543ec679649668e54749821116442
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2074159
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66476}
    eea168f8
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...