• Patrick Thier's avatar
    Reland "[turbofan] Improve StoreStoreElimination" · e926da45
    Patrick Thier authored
    This is a reland of 863bc2b8
    
    Diff to original:
    - Don't eliminate GC observable stores that were temporarily
      unobservable during traversal.
    - Skip the previously added test for single-generation
    - Add new test
    
    Original change's description:
    > [turbofan] Improve StoreStoreElimination
    >
    > Previously, StoreStoreElimination handled allocations as
    > "can observe anything". This is pretty conservative and prohibits
    > elimination of repeated double stores to the same field.
    > With this CL allocations are changed to "observes initializing or
    > transitioning stores".
    > This way it is guaranteed that initializing stores to a freshly created
    > object or stores that are part of a map transition are not eliminated
    > before allocations (that can trigger GC), but allows elimination of
    > non-initializing, non-transitioning, unobservable stores in the
    > presence of allocations.
    >
    > Bug: v8:12200
    > Change-Id: Ie1419696b9c8cb7c39aecf38d9f08102177b2c0f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295449
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Maya Lekova <mslekova@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#78230}
    
    Bug: v8:12200, chromium:1276923, v8:12477
    Change-Id: Ied45ee28ac12b370f7b232d2d338f93e10fea6b4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3320460Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78349}
    e926da45
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
security Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...