• Patrick Thier's avatar
    Reland "[turbofan] Improve StoreStoreElimination" · e926da45
    Patrick Thier authored
    This is a reland of 863bc2b8
    
    Diff to original:
    - Don't eliminate GC observable stores that were temporarily
      unobservable during traversal.
    - Skip the previously added test for single-generation
    - Add new test
    
    Original change's description:
    > [turbofan] Improve StoreStoreElimination
    >
    > Previously, StoreStoreElimination handled allocations as
    > "can observe anything". This is pretty conservative and prohibits
    > elimination of repeated double stores to the same field.
    > With this CL allocations are changed to "observes initializing or
    > transitioning stores".
    > This way it is guaranteed that initializing stores to a freshly created
    > object or stores that are part of a map transition are not eliminated
    > before allocations (that can trigger GC), but allows elimination of
    > non-initializing, non-transitioning, unobservable stores in the
    > presence of allocations.
    >
    > Bug: v8:12200
    > Change-Id: Ie1419696b9c8cb7c39aecf38d9f08102177b2c0f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3295449
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Maya Lekova <mslekova@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#78230}
    
    Bug: v8:12200, chromium:1276923, v8:12477
    Change-Id: Ied45ee28ac12b370f7b232d2d338f93e10fea6b4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3320460Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78349}
    e926da45
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...