• Jakob Gruber's avatar
    [compiler] Add more StartNode helpers · e75d8dbc
    Jakob Gruber authored
    Start nodes for JS functions have the following Parameter node value
    outputs:
    
     closure, ...args_including_receiver, new_target, argc, context
    
    This CL adds helper functions for these. There's two interesting
    gotcha's:
    
    - Each Parameter node is associated with an index, starting at -1.
    Value output indices obviously start at 0, so there's an off-by-one
    between the value output of the Parameter node, and the Parameter
    node's associated index.
    - CSA/Torque graphs use different Start node layouts, yet these are
    not reflected in compiler logic. There's potential for confusion here.
    The two layouts should be unified or made explicit.
    
    Finally, tests create Start nodes with arbitrary layouts. This blocks
    removal of methods marked _MaybeNonStandardLayout.
    
    In an ideal world, the parameter index would equal the start node
    output index, and the layout of all Start nodes would be equal. Future
    work..
    
    Change-Id: I908909880817979062d459b7a80ed4fede40e2ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649035
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72352}
    e75d8dbc
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...