• Jakob Gruber's avatar
    [compiler] Add more StartNode helpers · e75d8dbc
    Jakob Gruber authored
    Start nodes for JS functions have the following Parameter node value
    outputs:
    
     closure, ...args_including_receiver, new_target, argc, context
    
    This CL adds helper functions for these. There's two interesting
    gotcha's:
    
    - Each Parameter node is associated with an index, starting at -1.
    Value output indices obviously start at 0, so there's an off-by-one
    between the value output of the Parameter node, and the Parameter
    node's associated index.
    - CSA/Torque graphs use different Start node layouts, yet these are
    not reflected in compiler logic. There's potential for confusion here.
    The two layouts should be unified or made explicit.
    
    Finally, tests create Start nodes with arbitrary layouts. This blocks
    removal of methods marked _MaybeNonStandardLayout.
    
    In an ideal world, the parameter index would equal the start node
    output index, and the layout of all Start nodes would be equal. Future
    work..
    
    Change-Id: I908909880817979062d459b7a80ed4fede40e2ec
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649035
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72352}
    e75d8dbc
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...