• Benedikt Meurer's avatar
    [objects] No longer create short external strings. · e42e7fc8
    Benedikt Meurer authored
    This fixes String::MakeExternal() to bail out if the subject string
    doesn't fit a regular ExternalString, instead of creating a short
    external string. The observation here is that for short external strings
    the overhead of having to have the StringResource plus going to the
    runtime/C++ for each and every character access from JavaScript land
    is probably bigger than the anticipated benefits.
    
    If this turns out to be wrong and there's a real benefit, we should make
    use of ThinStrings instead of having a separate way to represent
    external strings.
    
    Bug: v8:6621, v8:7109, v8:7145
    Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d
    Reviewed-on: https://chromium-review.googlesource.com/799750Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49735}
    e42e7fc8
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...