• Benedikt Meurer's avatar
    [objects] No longer create short external strings. · e42e7fc8
    Benedikt Meurer authored
    This fixes String::MakeExternal() to bail out if the subject string
    doesn't fit a regular ExternalString, instead of creating a short
    external string. The observation here is that for short external strings
    the overhead of having to have the StringResource plus going to the
    runtime/C++ for each and every character access from JavaScript land
    is probably bigger than the anticipated benefits.
    
    If this turns out to be wrong and there's a real benefit, we should make
    use of ThinStrings instead of having a separate way to represent
    external strings.
    
    Bug: v8:6621, v8:7109, v8:7145
    Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d
    Reviewed-on: https://chromium-review.googlesource.com/799750Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49735}
    e42e7fc8
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...