• Dan Elphick's avatar
    [ReadOnlyRoots] Fix detection of initially RO mutable roots · e0670b22
    Dan Elphick authored
    TestHeapRootsNotReadOnly was mistakenly checking for exceptions to the
    rule by comparing the value of the root rather than the address. Since
    several roots point to UndefinedValue, this meant that only one of the
    matching roots had to be in the list.
    
    This fixes it by instead getting a Handle from Factory and using the
    address() method to check whether the roots match the exception list.
    
    Also adds detached_contexts, feedback_vectors_for_profiling_tools,
    microtask_queue, serialized_global_proxy_sizes and serialized_objects to
    the exception list now that the test is working properly.
    
    Change-Id: I599d584f94797a256d1c8c24c0fa2848ca1ca1df
    Reviewed-on: https://chromium-review.googlesource.com/1148331
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54647}
    e0670b22
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...