-
Dan Elphick authored
TestHeapRootsNotReadOnly was mistakenly checking for exceptions to the rule by comparing the value of the root rather than the address. Since several roots point to UndefinedValue, this meant that only one of the matching roots had to be in the list. This fixes it by instead getting a Handle from Factory and using the address() method to check whether the roots match the exception list. Also adds detached_contexts, feedback_vectors_for_profiling_tools, microtask_queue, serialized_global_proxy_sizes and serialized_objects to the exception list now that the test is working properly. Change-Id: I599d584f94797a256d1c8c24c0fa2848ca1ca1df Reviewed-on: https://chromium-review.googlesource.com/1148331 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54647}
e0670b22