• Dan Elphick's avatar
    [ReadOnlyRoots] Fix detection of initially RO mutable roots · e0670b22
    Dan Elphick authored
    TestHeapRootsNotReadOnly was mistakenly checking for exceptions to the
    rule by comparing the value of the root rather than the address. Since
    several roots point to UndefinedValue, this meant that only one of the
    matching roots had to be in the list.
    
    This fixes it by instead getting a Handle from Factory and using the
    address() method to check whether the roots match the exception list.
    
    Also adds detached_contexts, feedback_vectors_for_profiling_tools,
    microtask_queue, serialized_global_proxy_sizes and serialized_objects to
    the exception list now that the test is working properly.
    
    Change-Id: I599d584f94797a256d1c8c24c0fa2848ca1ca1df
    Reviewed-on: https://chromium-review.googlesource.com/1148331
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54647}
    e0670b22
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...