• Simon Zünd's avatar
    [stack-trace] Separate stack-trace symbolization and serialization · db24e200
    Simon Zünd authored
    This CL moves the code responsible for serializing a stack trace frame into
    a string, out of messages.cc and into stack-frame-info.cc. Instead of
    symbolizing the stack trace frame while serializing, the code is changed to
    work on top of StackTraceFrame and StackFrameInfo objects.
    
    The result is that the serialization code no longer cares when a stack trace
    frame is symbolized. Symbolization could happen eagerly during capturing, or
    lazily the first time any of StackFrameInfo fields are accessed.
    
    Drive-by: Existing users of StackFrameBase::ToString are adapted to the
    new SerializeStackTraceFrame API. This includes Isolate::PrintCurrentStackTrace,
    which is changed to re-use the existing capturing and serializing mechanism.
    
    Bug: v8:8742
    Change-Id: Ic7fd80668c9d993e99d586ef7fe022850104c34f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631414
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62522}
    db24e200
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...