• Simon Zünd's avatar
    [stack-trace] Separate stack-trace symbolization and serialization · db24e200
    Simon Zünd authored
    This CL moves the code responsible for serializing a stack trace frame into
    a string, out of messages.cc and into stack-frame-info.cc. Instead of
    symbolizing the stack trace frame while serializing, the code is changed to
    work on top of StackTraceFrame and StackFrameInfo objects.
    
    The result is that the serialization code no longer cares when a stack trace
    frame is symbolized. Symbolization could happen eagerly during capturing, or
    lazily the first time any of StackFrameInfo fields are accessed.
    
    Drive-by: Existing users of StackFrameBase::ToString are adapted to the
    new SerializeStackTraceFrame API. This includes Isolate::PrintCurrentStackTrace,
    which is changed to re-use the existing capturing and serializing mechanism.
    
    Bug: v8:8742
    Change-Id: Ic7fd80668c9d993e99d586ef7fe022850104c34f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631414
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62522}
    db24e200
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...