• Mike Stanton's avatar
    [TurboFan] Check deoptimized status on CodeRef · d2cb2ae6
    Mike Stanton authored
    When making inlining decisions, we are interested in
    CodeRef::inlined_bytecode_size(). Previously, we gated a check of this
    value on predicate JSFunctionRef::HasAttachedOptimizedCode(), but we
    removed this predicate because it only recorded a value seen at
    serialization time.
    
    Now, we look at attached CodeRefs "live," which means we might discover
    that the code is now optimized, where it wasn't at serialization time.
    This affects the inlining decision. This CL adds an additional check
    before returning a non-zero inlined_bytecode_size that the code object
    hasn't (already) been deoptimized. It's logical to do this, because the
    inlined_bytecode_size is actually a stale value at this point.
    
    Bug: chromium:1180749
    Change-Id: I4d55132c5b47083413d3c6b1d934bfce6b550709
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712565
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72960}
    d2cb2ae6
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...