• Mike Stanton's avatar
    [TurboFan] Check deoptimized status on CodeRef · d2cb2ae6
    Mike Stanton authored
    When making inlining decisions, we are interested in
    CodeRef::inlined_bytecode_size(). Previously, we gated a check of this
    value on predicate JSFunctionRef::HasAttachedOptimizedCode(), but we
    removed this predicate because it only recorded a value seen at
    serialization time.
    
    Now, we look at attached CodeRefs "live," which means we might discover
    that the code is now optimized, where it wasn't at serialization time.
    This affects the inlining decision. This CL adds an additional check
    before returning a non-zero inlined_bytecode_size that the code object
    hasn't (already) been deoptimized. It's logical to do this, because the
    inlined_bytecode_size is actually a stale value at this point.
    
    Bug: chromium:1180749
    Change-Id: I4d55132c5b47083413d3c6b1d934bfce6b550709
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2712565
    Commit-Queue: Michael Stanton <mvstanton@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72960}
    d2cb2ae6
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...