• Clemens Backes's avatar
    [wasm][debug] Only inspect code generated for debugging · cfe1b64b
    Clemens Backes authored
    Liftoff code generated for debugging has an extended function prologue
    which checks the "hook on function entry" flag on the isolate. Because
    of this, code positions between standard Liftoff code and Liftoff code
    for debugging do not match up. When (lazily) generating debug side
    tables, we always generate them for debugging-flavored Liftoff code.
    
    The issue that this CL fixes happened when we tried to inspect non-debug
    Liftoff code, and lazily generated the debug side table for that code.
    As noted above, source positions would not match up in that case, and we
    get DCHECK failures (or crashes in release builds) when inspecting the
    code.
    
    This issue was uncovered as part of the multi-threaded debugging effort,
    but because of the similarity in the stack trace, it might also fix the
    other issues linked below. We will get test coverage as soon as we add
    multi-threaded debugging tests (which are in development, but are still
    hitting other issues).
    
    R=thibaudm@chromium.org
    
    Bug: v8:10359, chromium:1071757, chromium:1079328, chromium:1072839
    Change-Id: Ic0c14e635dc2a0b84ac86ceb6650288202dafedc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196349
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67756}
    cfe1b64b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...