• Clemens Backes's avatar
    [wasm][debug] Only inspect code generated for debugging · cfe1b64b
    Clemens Backes authored
    Liftoff code generated for debugging has an extended function prologue
    which checks the "hook on function entry" flag on the isolate. Because
    of this, code positions between standard Liftoff code and Liftoff code
    for debugging do not match up. When (lazily) generating debug side
    tables, we always generate them for debugging-flavored Liftoff code.
    
    The issue that this CL fixes happened when we tried to inspect non-debug
    Liftoff code, and lazily generated the debug side table for that code.
    As noted above, source positions would not match up in that case, and we
    get DCHECK failures (or crashes in release builds) when inspecting the
    code.
    
    This issue was uncovered as part of the multi-threaded debugging effort,
    but because of the similarity in the stack trace, it might also fix the
    other issues linked below. We will get test coverage as soon as we add
    multi-threaded debugging tests (which are in development, but are still
    hitting other issues).
    
    R=thibaudm@chromium.org
    
    Bug: v8:10359, chromium:1071757, chromium:1079328, chromium:1072839
    Change-Id: Ic0c14e635dc2a0b84ac86ceb6650288202dafedc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2196349
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67756}
    cfe1b64b
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...