• ofrobots's avatar
    Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset... · cf050cc2
    ofrobots authored
    Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset #2 id:20001 of https://codereview.chromium.org/1390013002/ )
    
    Reason for revert:
    Causes memory footprint regression: https://code.google.com/p/chromium/issues/detail?id=541135
    
    The intent of the code here was to advance the inline allocation limit without counting the allocated memory towards a step. Calling LowerInlineAllocationLimit this way is a blunt way of doing it, but it works.
    
    At this point it is simplest to revert this CL. My follow-on CL (https://codereview.chromium.org/1404523002/) can address the 'bluntness' of calling LowerInlineAllocationLimit from here along with leaving a comment about the intent.
    
    revert_cq: 1
    revert_reason_textarea: Causes memory footprint regression: https://code.google.com/p/chromium/issues/detail?id=541135
    
    The intent of the code here was to advance the inline allocation limit without counting the allocated memory towards a step. Calling LowerInlineAllocationLimit this way is a blunt way of doing it, but it works.
    
    At this point it is simplest to revert this CL. My follow-on CL (https://codereview.chromium.org/1404523002/) can address the 'bluntness' of calling LowerInlineAllocationLimit from here along with leaving a comment about the intent.
    
    Original issue's description:
    > [heap] remove unneeded call to LowerInlineAllocationLimit
    >
    > Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to be
    > a no-op.
    >
    >   new_space_.LowerInlineAllocationLimit(
    >       new_space_.inline_allocation_limit_step());
    >
    > LowerInlineAllocatoinLimit does the following things:
    >
    > 1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
    > 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
    >    already been called when new_space_.ResetAllocationInfo was called above.
    > 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
    >    ResetAllocationInfo as well.
    >
    > BUG=
    > R=hpayer@chromium.org,ulan@chromium.org
    >
    > Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7
    > Cr-Commit-Position: refs/heads/master@{#31156}
    
    TBR=hpayer@chromium.org,ulan@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:541135
    LOG=n
    
    Review URL: https://codereview.chromium.org/1405043005
    
    Cr-Commit-Position: refs/heads/master@{#31574}
    cf050cc2
Name
Last commit
Last update
..
OWNERS Loading commit data...
array-buffer-tracker.cc Loading commit data...
array-buffer-tracker.h Loading commit data...
gc-idle-time-handler.cc Loading commit data...
gc-idle-time-handler.h Loading commit data...
gc-tracer.cc Loading commit data...
gc-tracer.h Loading commit data...
heap-inl.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-inl.h Loading commit data...
incremental-marking-job.cc Loading commit data...
incremental-marking-job.h Loading commit data...
incremental-marking.cc Loading commit data...
incremental-marking.h Loading commit data...
mark-compact-inl.h Loading commit data...
mark-compact.cc Loading commit data...
mark-compact.h Loading commit data...
memory-reducer.cc Loading commit data...
memory-reducer.h Loading commit data...
object-stats.cc Loading commit data...
object-stats.h Loading commit data...
objects-visiting-inl.h Loading commit data...
objects-visiting.cc Loading commit data...
objects-visiting.h Loading commit data...
scavenge-job.cc Loading commit data...
scavenge-job.h Loading commit data...
scavenger-inl.h Loading commit data...
scavenger.cc Loading commit data...
scavenger.h Loading commit data...
slots-buffer.cc Loading commit data...
slots-buffer.h Loading commit data...
spaces-inl.h Loading commit data...
spaces.cc Loading commit data...
spaces.h Loading commit data...
store-buffer-inl.h Loading commit data...
store-buffer.cc Loading commit data...
store-buffer.h Loading commit data...