• ofrobots's avatar
    Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset... · cf050cc2
    ofrobots authored
    Revert of [heap] remove unneeded call to LowerInlineAllocationLimit (patchset #2 id:20001 of https://codereview.chromium.org/1390013002/ )
    
    Reason for revert:
    Causes memory footprint regression: https://code.google.com/p/chromium/issues/detail?id=541135
    
    The intent of the code here was to advance the inline allocation limit without counting the allocated memory towards a step. Calling LowerInlineAllocationLimit this way is a blunt way of doing it, but it works.
    
    At this point it is simplest to revert this CL. My follow-on CL (https://codereview.chromium.org/1404523002/) can address the 'bluntness' of calling LowerInlineAllocationLimit from here along with leaving a comment about the intent.
    
    revert_cq: 1
    revert_reason_textarea: Causes memory footprint regression: https://code.google.com/p/chromium/issues/detail?id=541135
    
    The intent of the code here was to advance the inline allocation limit without counting the allocated memory towards a step. Calling LowerInlineAllocationLimit this way is a blunt way of doing it, but it works.
    
    At this point it is simplest to revert this CL. My follow-on CL (https://codereview.chromium.org/1404523002/) can address the 'bluntness' of calling LowerInlineAllocationLimit from here along with leaving a comment about the intent.
    
    Original issue's description:
    > [heap] remove unneeded call to LowerInlineAllocationLimit
    >
    > Calling LowerInlineAllocationLimit from the bottom of Heap::Scavenge seems to be
    > a no-op.
    >
    >   new_space_.LowerInlineAllocationLimit(
    >       new_space_.inline_allocation_limit_step());
    >
    > LowerInlineAllocatoinLimit does the following things:
    >
    > 1. Set the inline_allocation_limit_step_ to the passed in value. No-op.
    > 2. Calls UpdateInlineAllocationLimit(0). This is unnecessary here as it has
    >    already been called when new_space_.ResetAllocationInfo was called above.
    > 3. Sets top_on_previous_step_. This again is unnecessary as it gets reached by
    >    ResetAllocationInfo as well.
    >
    > BUG=
    > R=hpayer@chromium.org,ulan@chromium.org
    >
    > Committed: https://crrev.com/9f8e8b835a468b1622c5350a01a97bc32c5b2fb7
    > Cr-Commit-Position: refs/heads/master@{#31156}
    
    TBR=hpayer@chromium.org,ulan@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:541135
    LOG=n
    
    Review URL: https://codereview.chromium.org/1405043005
    
    Cr-Commit-Position: refs/heads/master@{#31574}
    cf050cc2
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...