• Rob Paveza's avatar
    SHA256 hash crash: GetScriptHash · c4d09aef
    Rob Paveza authored
    Initialization after reset + unnecessary use of handle scope appear to
    be the culprit here. Most of the other functions in debug::Script do not
    use HandleScope, so this reconciles these differences. Additionally,
    the call to obtain and initialize the hash within
    ActualScript::Initialize was inconsistent: all of the other fields were
    initialized prior to resetting the script and source.
    
    These reconciliations appear to fix this crash.
    
    Bug: chromium:1325036
    Change-Id: Ia86e83b6c99955a3ac80a4a8845c0df0172e991c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648082
    Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Auto-Submit: Robert Paveza <Rob.Paveza@microsoft.com>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80760}
    c4d09aef
Name
Last commit
Last update
..
BUILD.gn Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
custom-preview.cc Loading commit data...
custom-preview.h Loading commit data...
injected-script.cc Loading commit data...
injected-script.h Loading commit data...
inspected-context.cc Loading commit data...
inspected-context.h Loading commit data...
inspector_protocol_config.json Loading commit data...
remote-object-id.cc Loading commit data...
remote-object-id.h Loading commit data...
search-util.cc Loading commit data...
search-util.h Loading commit data...
string-16.cc Loading commit data...
string-16.h Loading commit data...
string-util.cc Loading commit data...
string-util.h Loading commit data...
test-interface.cc Loading commit data...
test-interface.h Loading commit data...
v8-console-agent-impl.cc Loading commit data...
v8-console-agent-impl.h Loading commit data...
v8-console-message.cc Loading commit data...
v8-console-message.h Loading commit data...
v8-console.cc Loading commit data...
v8-console.h Loading commit data...
v8-debugger-agent-impl.cc Loading commit data...
v8-debugger-agent-impl.h Loading commit data...
v8-debugger-id.cc Loading commit data...
v8-debugger-id.h Loading commit data...
v8-debugger-script.cc Loading commit data...
v8-debugger-script.h Loading commit data...
v8-debugger.cc Loading commit data...
v8-debugger.h Loading commit data...
v8-heap-profiler-agent-impl.cc Loading commit data...
v8-heap-profiler-agent-impl.h Loading commit data...
v8-inspector-impl.cc Loading commit data...
v8-inspector-impl.h Loading commit data...
v8-inspector-session-impl.cc Loading commit data...
v8-inspector-session-impl.h Loading commit data...
v8-profiler-agent-impl.cc Loading commit data...
v8-profiler-agent-impl.h Loading commit data...
v8-regex.cc Loading commit data...
v8-regex.h Loading commit data...
v8-runtime-agent-impl.cc Loading commit data...
v8-runtime-agent-impl.h Loading commit data...
v8-schema-agent-impl.cc Loading commit data...
v8-schema-agent-impl.h Loading commit data...
v8-stack-trace-impl.cc Loading commit data...
v8-stack-trace-impl.h Loading commit data...
v8-string-conversions.cc Loading commit data...
v8-string-conversions.h Loading commit data...
v8-value-utils.cc Loading commit data...
v8-value-utils.h Loading commit data...
v8-webdriver-serializer.cc Loading commit data...
v8-webdriver-serializer.h Loading commit data...
value-mirror.cc Loading commit data...
value-mirror.h Loading commit data...