• Rob Paveza's avatar
    SHA256 hash crash: GetScriptHash · c4d09aef
    Rob Paveza authored
    Initialization after reset + unnecessary use of handle scope appear to
    be the culprit here. Most of the other functions in debug::Script do not
    use HandleScope, so this reconciles these differences. Additionally,
    the call to obtain and initialize the hash within
    ActualScript::Initialize was inconsistent: all of the other fields were
    initialized prior to resetting the script and source.
    
    These reconciliations appear to fix this crash.
    
    Bug: chromium:1325036
    Change-Id: Ia86e83b6c99955a3ac80a4a8845c0df0172e991c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3648082
    Commit-Queue: Robert Paveza <Rob.Paveza@microsoft.com>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Auto-Submit: Robert Paveza <Rob.Paveza@microsoft.com>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80760}
    c4d09aef
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...