• Tobias Tebbi's avatar
    [turbofan] use ZoneUnorderedMap for NodeCache · c0c3b207
    Tobias Tebbi authored
    This fixes a non-determinism issue caused by the cache being full.
    Depending on the non-deterministic value of the handles in HeapConstant
    nodes, different cache entries would be overwritten in this case.
    
    The old implementation of NodeCache had a fixed limit, overwriting
    entries when the cache is full. This behavior didn't really make sense,
    but the hand-written hash map implementation couldn't handle arbitrary
    numbers of hash collisions, so removing the limit wasn't an option either.
    Thus this CL just replaces the custom hash map with a normal
    std::unordered_map, that is, a ZoneUnorderedMap.
    
    Bug: chromium:1046815
    Change-Id: I95269f2b1068eb9dfe3ee2ab5cca1cb460bc8fa3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087405Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66592}
    c0c3b207
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...