• Tobias Tebbi's avatar
    [turbofan] use ZoneUnorderedMap for NodeCache · c0c3b207
    Tobias Tebbi authored
    This fixes a non-determinism issue caused by the cache being full.
    Depending on the non-deterministic value of the handles in HeapConstant
    nodes, different cache entries would be overwritten in this case.
    
    The old implementation of NodeCache had a fixed limit, overwriting
    entries when the cache is full. This behavior didn't really make sense,
    but the hand-written hash map implementation couldn't handle arbitrary
    numbers of hash collisions, so removing the limit wasn't an option either.
    Thus this CL just replaces the custom hash map with a normal
    std::unordered_map, that is, a ZoneUnorderedMap.
    
    Bug: chromium:1046815
    Change-Id: I95269f2b1068eb9dfe3ee2ab5cca1cb460bc8fa3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2087405Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66592}
    c0c3b207
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...