• Sigurd Schneider's avatar
    Reland "[exceptions] Don't re-request interrupt in InvokeWithTryCatch" · b9df6e1c
    Sigurd Schneider authored
    This is a reland of 4ed9d48f
    
    CompileRun leads to undefined behavior if the compile fails;
    CompileRunChecked can be used to assert that the compile must
    succeed. I've removed the attempt to compile and rely on a
    simpler check in the tests now.
    
    Original change's description:
    > [exceptions] Don't re-request interrupt in InvokeWithTryCatch
    >
    > This CL changes InvokeWithTryCatch to not re-request the terminate
    > execution interrupt, but instead schedule the termination exception.
    > This ensures that leaving the outermost TryCatch scope will clear
    > the exception, and no interrupt remains.
    >
    > Previously, the interrupt request could remain and prevent further
    > JavaScript execution even after the TryCatch scope was left.
    >
    > Change-Id: I1e603dc822bbcb0def4cf0a898d59cf8d4b9d039
    > Bug: chromium:1014415
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871910
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65255}
    
    Tbr: yangguo@chromium.org, verwaest@chromium.org
    Bug: chromium:1014415
    Change-Id: I29444c4b7ea5a158865f54d4608f374914f7b133
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943151Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65258}
    b9df6e1c
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...