• Benedikt Meurer's avatar
    [inspector] Add internal property to identify detached ArrayBuffers. · b886e153
    Benedikt Meurer authored
    This adds an internal property [[IsDetached]] to the inspector preview
    of ArrayBuffer instances, which indicates whether the ArrayBuffer was
    detached (i.e. transfered via `postMessage`). Previously it was rather
    impossible to tell whether an ArrayBuffer was detached, you had to know
    that V8 violates the ECMAScript specification and simply sets the
    byteLength accessor to 0 upon detaching an ArrayBuffer (but even then it
    was still impossible to tell whether that ArrayBuffer wasn't simply an
    empty one from the get go).
    
    Before: https://imgur.com/UcOF83c
    After: https://imgur.com/WjmTehZ
    
    Fixed: chromium:1109102
    Change-Id: I8fb6e2be2fbfe5c62b05dc9d2a0f18378eb4de6c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316075
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69034}
    b886e153
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...