• Benedikt Meurer's avatar
    [inspector] Add internal property to identify detached ArrayBuffers. · b886e153
    Benedikt Meurer authored
    This adds an internal property [[IsDetached]] to the inspector preview
    of ArrayBuffer instances, which indicates whether the ArrayBuffer was
    detached (i.e. transfered via `postMessage`). Previously it was rather
    impossible to tell whether an ArrayBuffer was detached, you had to know
    that V8 violates the ECMAScript specification and simply sets the
    byteLength accessor to 0 upon detaching an ArrayBuffer (but even then it
    was still impossible to tell whether that ArrayBuffer wasn't simply an
    empty one from the get go).
    
    Before: https://imgur.com/UcOF83c
    After: https://imgur.com/WjmTehZ
    
    Fixed: chromium:1109102
    Change-Id: I8fb6e2be2fbfe5c62b05dc9d2a0f18378eb4de6c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316075
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69034}
    b886e153
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...