• machenbach's avatar
    Revert of [turbofan] Remove left-over change bits from ChangeLowering.... · b4c3864b
    machenbach authored
    Revert of [turbofan] Remove left-over change bits from ChangeLowering. (patchset #2 id:20001 of https://codereview.chromium.org/1941673002/ )
    
    Reason for revert:
    [Sheriff] Breaks mac gc stress:
    https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/5821
    
    Original issue's description:
    > [turbofan] Remove left-over change bits from ChangeLowering.
    >
    > Now ChangeLowering is only concerned with lowering memory access and
    > allocation operations, and all changes are consistently lowered during
    > the effect/control linearization pass. The next step is to move the
    > left over lowerings to a pass dedicated to eliminate redundant loads and
    > stores, eliminate write barriers, fold and inline allocations.
    >
    > Also remove the atomic regions now that we wire everything into the
    > effect chain properly. This is an important step towards allocation
    > inlining.
    >
    > Drive-by-fix: Rename ChangeBitToBool to ChangeBitToTagged,
    > ChangeBoolToBit to ChangeTaggedToBit, and ChangeInt31ToTagged to
    > ChangeInt31ToTaggedSigned for consistency.
    >
    > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux64_tsan_rel
    >
    > Committed: https://crrev.com/ceca5ae308bddda166651c654f96d71d74f617d0
    > Cr-Commit-Position: refs/heads/master@{#35924}
    
    TBR=ishell@chromium.org,bmeurer@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/1942733002
    Cr-Commit-Position: refs/heads/master@{#35927}
    b4c3864b
Name
Last commit
Last update
..
base Loading commit data...
compiler Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
wasm Loading commit data...
DEPS Loading commit data...
atomic-utils-unittest.cc Loading commit data...
cancelable-tasks-unittest.cc Loading commit data...
char-predicates-unittest.cc Loading commit data...
counters-unittest.cc Loading commit data...
locked-queue-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
unittests.gyp Loading commit data...
unittests.isolate Loading commit data...
unittests.status Loading commit data...