• vabr's avatar
    Fix TypeError message for Reflect.construct · b478e9c1
    vabr authored
    If the Reflect.construct receives an argument expected to be a constructor,
    and the argument is not a constructor, V8 currently declares that
    Reflect.construct is not a function. It should instead say that the offending
    argument is not a constructor.
    
    This is the case for all ports of builtins
    (Builtins::Generate_ReflectConstruct). All of them make an
    attempt to at least pass the right argument to the TypeError parametrised
    message, calling out the offending Reflect.construct argument. However,
    Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
    discarding the precise information.
    
    This CL adds Runtime::kNotConstructor, which reports the arguments passed
    to it, and the CL also modifies the ports of builtins to make use of
    Runtime::kNotConstructor
    
    BUG=v8:5671
    
    Review-Url: https://codereview.chromium.org/2688393003
    Cr-Commit-Position: refs/heads/master@{#43182}
    b478e9c1
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
x87 Loading commit data...
builtins-api.cc Loading commit data...
builtins-arguments.cc Loading commit data...
builtins-arguments.h Loading commit data...
builtins-array.cc Loading commit data...
builtins-arraybuffer.cc Loading commit data...
builtins-async-function.cc Loading commit data...
builtins-async.cc Loading commit data...
builtins-async.h Loading commit data...
builtins-boolean.cc Loading commit data...
builtins-call.cc Loading commit data...
builtins-callsite.cc Loading commit data...
builtins-constructor.cc Loading commit data...
builtins-constructor.h Loading commit data...
builtins-conversion.cc Loading commit data...
builtins-dataview.cc Loading commit data...
builtins-date.cc Loading commit data...
builtins-debug.cc Loading commit data...
builtins-error.cc Loading commit data...
builtins-function.cc Loading commit data...
builtins-generator.cc Loading commit data...
builtins-global.cc Loading commit data...
builtins-handler.cc Loading commit data...
builtins-ic.cc Loading commit data...
builtins-internal.cc Loading commit data...
builtins-interpreter.cc Loading commit data...
builtins-json.cc Loading commit data...
builtins-math.cc Loading commit data...
builtins-number.cc Loading commit data...
builtins-object.cc Loading commit data...
builtins-object.h Loading commit data...
builtins-promise.cc Loading commit data...
builtins-promise.h Loading commit data...
builtins-proxy.cc Loading commit data...
builtins-reflect.cc Loading commit data...
builtins-regexp.cc Loading commit data...
builtins-regexp.h Loading commit data...
builtins-sharedarraybuffer.cc Loading commit data...
builtins-string.cc Loading commit data...
builtins-symbol.cc Loading commit data...
builtins-typedarray.cc Loading commit data...
builtins-utils.h Loading commit data...
builtins.cc Loading commit data...
builtins.h Loading commit data...