• vabr's avatar
    Fix TypeError message for Reflect.construct · b478e9c1
    vabr authored
    If the Reflect.construct receives an argument expected to be a constructor,
    and the argument is not a constructor, V8 currently declares that
    Reflect.construct is not a function. It should instead say that the offending
    argument is not a constructor.
    
    This is the case for all ports of builtins
    (Builtins::Generate_ReflectConstruct). All of them make an
    attempt to at least pass the right argument to the TypeError parametrised
    message, calling out the offending Reflect.construct argument. However,
    Runtime::kThrowCalledNonCallable extracts the callsite from those arguments,
    discarding the precise information.
    
    This CL adds Runtime::kNotConstructor, which reports the arguments passed
    to it, and the CL also modifies the ports of builtins to make use of
    Runtime::kNotConstructor
    
    BUG=v8:5671
    
    Review-Url: https://codereview.chromium.org/2688393003
    Cr-Commit-Position: refs/heads/master@{#43182}
    b478e9c1
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...