• Omer Katz's avatar
    cppgc: Fix flaky crash due to used bytes counters mismatch · acb0263c
    Omer Katz authored
    Cppgc reports used bytes statistics to CppHeap. CppHeap should forward
    the stats to v8. However, if we are not allowed to trigger a GC, CppHeap
    will cache the stats until the reporting.
    On GC finalization, CppHeap resets v8's counters to the current marked
    bytes counter.
    If the last reported stats before GC finalization are cached, CppHeap
    doesn't clear the cache on GC finalization. On the next stats reporting,
    CppHeap will report the cached values. If the cache is a decrease that
    is larger than the current marked bytes, a DCHECK in
    LocalEmbedderHeapTracer::DecreaseAllocatedSize will fail.
    
    Bug: chromium:1056170
    Change-Id: I47933abc3e5f5c4a91454e0ec03adde5cf61d8fc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056970
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75986}
    acb0263c
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...