• Omer Katz's avatar
    cppgc: Fix flaky crash due to used bytes counters mismatch · acb0263c
    Omer Katz authored
    Cppgc reports used bytes statistics to CppHeap. CppHeap should forward
    the stats to v8. However, if we are not allowed to trigger a GC, CppHeap
    will cache the stats until the reporting.
    On GC finalization, CppHeap resets v8's counters to the current marked
    bytes counter.
    If the last reported stats before GC finalization are cached, CppHeap
    doesn't clear the cache on GC finalization. On the next stats reporting,
    CppHeap will report the cached values. If the cache is a decrease that
    is larger than the current marked bytes, a DCHECK in
    LocalEmbedderHeapTracer::DecreaseAllocatedSize will fail.
    
    Bug: chromium:1056170
    Change-Id: I47933abc3e5f5c4a91454e0ec03adde5cf61d8fc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056970
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75986}
    acb0263c
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...