• Clemens Backes's avatar
    [wasm] Remove a long-living CodeSpaceWriteScope · a8609e06
    Clemens Backes authored
    The {CodeSpaceWriteScope} in {InstanceBuilder::Build} was kept open
    while processing imports, which could compile another wasm module via
    {compiler::ResolveWasmImportCall} and
    {WasmEngine::SyncCompileTranslatedAsmJs}. This leads to errors since
    {CodeSpaceWriteScope}s for different modules cannot be held open at the
    same time.
    
    This CL fixes that by only opening the {CodeSpaceWriteScope} for the
    actual compilation of import wrappers.
    
    Drive-by: Only call {ProcessImports} if there are imports to be
    processed, to avoid some of the overhead of {ProcessImports} and
    {CompileImportWrappers}.
    
    R=jkummerow@chromium.org
    
    Bug: chromium:1239522
    Change-Id: Ifbaf64a4be92088ae4a3fd7e9700a33397b2a967
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097283
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76311}
    a8609e06
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...